Re: [PATCH v3 1/3] gdb, gdbserver, zpoint: report z_point support

[Tom Tromey <tom@tromey.com>]

>>>>> Mohamed Bouhaouel <mohamed.bouhaouel@intel.com> writes:

> Make gdbserver report which types of breakpoints and watchpoints
> are supported when exchanging features.  This is done by replying with
> Z<type>+ (Supported) or Z<type>- (unsupported)

Thanks for the patch.

I suppose the idea is that this work can't really be done on the gdb
side, because gdb creates the watchpoint and such earlier, and only then
tries to communicate with the remote... so errors come too late?

> +@item Z@var{type}
> +The remote stub reports which types of breakpoints and watchpoints are
> +supported.  This is done using flags, @samp{Z@var{type}+} for supported

I think this part of the docs should mention that the 'Z' response
assumes that both of the corresponding 'z' and 'Z' packets are
supported.

> +  return (m_features.packet_support (PACKET_Z0 + packet) != PACKET_DISABLE);

Too many parens.

> +/* Returns true if Z_TYPE is supported by the target.  */
> +
> +int z_type_supported (char z_type);
>  #endif /* GDBSERVER_MEM_BREAK_H */

Should have a newline before the #endif.

Tom