From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AFDCA3858C2C for ; Tue, 24 Oct 2023 12:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFDCA3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFDCA3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698149015; cv=none; b=FP2D/1gcFRRu3wtDIxl++L59p7etX1uaIQSKF9O/G+vESt+nLpnk6Oylx6TMjyaGkDGP64EbNMrn0LQ1WGY5AWoONvg22YY78uJ7Z1XlbgXUAvC4RIHEx/EBDlqu4NRLrFbjkut4nI0iwnLOu1TecVUioRFdyvHBXTRPdPs00VU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698149015; c=relaxed/simple; bh=f6p01JAdEC8urFQi4exXMCqRVeHEKkBifa9Q+pu400Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aak2zyNeCzH/QoR/a8VCaX4AFi/5F+f7s7EUVMsWWvfVgszYd6aYTVXhr225SfLp8jXpm9TCn4Za2FxE6wiz/zNYz4OL0JuqNH4eXVdxh0OTm2YzmVR0k2iJpQ0YamTZ33gKfuiY1YZvph1NVdz3lefxMjC0fjUnJJzEkobINs0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698149014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lRs3iYQAE8iTtTxGj1l2DwrAXROjmR3hbzQdkDQOXsw=; b=TM4p6XPjkpcaqovq8zgarlCYEcu57Zoz0ixUOPBhQohyWljTLKcQMjEkvJiryOaG5qdiOK 4rSu5m4ax2hTGhpLIcUUv+HkQC+66SZv8L+8by49RJCCidduJgaOjPU2wpHKIpCym+X3H9 qIG2ER8a72uvCMYXNn4pSkXbl4f0LXY= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-uSjkh_BUPUW-c-TnMNPdFg-1; Tue, 24 Oct 2023 08:03:33 -0400 X-MC-Unique: uSjkh_BUPUW-c-TnMNPdFg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-9c75886c044so240638766b.2 for ; Tue, 24 Oct 2023 05:03:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698149012; x=1698753812; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lRs3iYQAE8iTtTxGj1l2DwrAXROjmR3hbzQdkDQOXsw=; b=p5E58iPELPwKIh6yf8Xvc8L776EPmHEhoc29tKecwLliSaCFsAPbGdD1gWYbWrgEtr nCeq3RI1SRDF29c7y8LK0b7N8dMBG6YjC7DppS+ULSz2q600ZbnAo/X3Kap/Hg11e0Hs u/cnJiFD8OBFwJ3v6wunDWdBMwmDk5mOwWYLtETRVGHcrOIEilSQ8qtgeKyxm8mmUgps JSpzTsE3qNWEfGCzGCcm38pZSmOyAsTsbCyFtIA3QfnW58lRMmCcq57z+rvEn5MCPHzJ YJ/1Kq87ZxLxDRE6jXetaolxQ7ozMpzE+3NDFFSSVo+O1KwCCj9IZsfA/YCuP7/Joi/f U+9A== X-Gm-Message-State: AOJu0Yypyy9dvnA2lAS4ahY4hTXt+7lhd1mMMr7VHGDRxoFQ3TDtH21y 4F4SDMC4hdrqL/unEBEP0n1PrBOf/63sIclCKYD44S+fgQ0cSlIYwP1ScLQvAj2vb9stOxUGW2W leSfabCJkuweNx0hrKp2s/+6on36KsA== X-Received: by 2002:a17:907:9306:b0:9be:b43c:38db with SMTP id bu6-20020a170907930600b009beb43c38dbmr8876809ejc.5.1698149011950; Tue, 24 Oct 2023 05:03:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYBTcJtjmknv6jyqKR1jme9eRL3gNsPG/6awq2N7waxg/H8pJ813kQ+s65rBFzLS8VSbOZBg== X-Received: by 2002:a17:907:9306:b0:9be:b43c:38db with SMTP id bu6-20020a170907930600b009beb43c38dbmr8876792ejc.5.1698149011553; Tue, 24 Oct 2023 05:03:31 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id jl24-20020a17090775d800b0099315454e76sm8072641ejc.211.2023.10.24.05.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 05:03:31 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] gdb: refactor objfile::find_and_add_separate_symbol_file In-Reply-To: <877cnhp4j2.fsf@tromey.com> References: <108c51107d11eae41fd77d54d73613569875c4c7.1697626088.git.aburgess@redhat.com> <877cnhp4j2.fsf@tromey.com> Date: Tue, 24 Oct 2023 13:03:30 +0100 Message-ID: <87jzrc2pnx.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> This is purely a refactoring commit. > Andrew> This commit splits objfile::find_and_add_separate_symbol_file into > Andrew> some separate helper functions. My hope is that the steps for looking > Andrew> up separate debug information are now clearer. > > Andrew> In a later commit I'm going to extend > Andrew> objfile::find_and_add_separate_symbol_file, with some additional > Andrew> logic, so starting with a simpler function will make the following > Andrew> changes easier. > > Andrew> There should be no user visible changes after this commit. > > Andrew> +static std::pair > Andrew> +simple_find_and_open_separate_symbol_file > ... > Andrew> + result = simple_find_and_open_separate_symbol_file > Andrew> + (this, find_separate_debug_file_by_buildid, &warnings); > ... > Andrew> + if (result.first == nullptr) > > If this happens to go in after the C++17 series, this code could be > cleaned up a little using structured bindings. I'll keep that in mind. Thanks, Andrew