From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Add regression test for instructionReference change
Date: Mon, 02 Oct 2023 13:51:09 -0600 [thread overview]
Message-ID: <87jzs4ztua.fsf@tromey.com> (raw)
In-Reply-To: <20230921145159.476643-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 21 Sep 2023 08:51:59 -0600")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> Yesterday I pushed a patch to fix a small oversight in the DAP code
Tom> that caused an instructionReference to be an array instead of a
Tom> string.
Tom> This patch adds a test case for that regression. This required
Tom> exposing the TON form of the response -- something I mentioned might
Tom> be necessary when this code was changed to return just the Tcl form.
Tom> I tested this by backing out yesterday's bug fix and verifying that a
Tom> failure is seen.
I'm checking this in.
Tom
prev parent reply other threads:[~2023-10-02 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:51 Tom Tromey
2023-10-02 19:51 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzs4ztua.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).