From: Tom Tromey <tromey@adacore.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid buffer overflow in ada_decode
Date: Wed, 16 Aug 2023 13:07:21 -0600 [thread overview]
Message-ID: <87jztuyffa.fsf@tromey.com> (raw)
In-Reply-To: <54cd2609-2526-5ff6-37cb-640ace0c128a@redhat.com> (Keith Seitz's message of "Wed, 16 Aug 2023 10:56:39 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> On 8/16/23 10:31, Tom Tromey via Gdb-patches wrote:
>> A bug report pointed out a buffer overflow in ada_decode, which Keith
>> helpfully analyzed. ada_decode had a logic error when the input was
>> all digits. While this isn't valid -- and would probably only appear
>> in fuzzer tests -- it still should be handled properly.
>> This patch adds a missing bounds check. Tested with the self-tests
>> in
>> an asan build.
Keith> That's excellent. Thank you for the quick turnaround!
Keith> Reviewed-by: Keith Seitz <keiths@redhat.com>
Thanks. I'm going to check this in.
Tom
prev parent reply other threads:[~2023-08-16 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 17:31 Tom Tromey
2023-08-16 17:56 ` Keith Seitz
2023-08-16 19:07 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jztuyffa.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).