From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 97F043858D1E for ; Wed, 2 Aug 2023 19:34:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97F043858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-34932982295so652815ab.2 for ; Wed, 02 Aug 2023 12:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691004844; x=1691609644; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HwthBYp5vTxg58iDSn4M15H6vIlHS5/2yucv+b6GQN4=; b=NA3aAm6AW2F7aD18dYYFbcVuN6DjR30RwMC1Ndrev7zYqIgLGcFRiDJRTtBDKM8djk xXBlk5dOVGNXo3aJPezI4ZM5UKzNiUCUEE/sjzmU8yhgYoXq6BJGCm0VtyHAr4lO58fG AwZDqF0Q2NWzx7jQDMIfE3MZXMlW+6FQtGJ+860jcBZzKVTAVqXEDo/bbGSXLMaKudag 8KuUAfpZ88gzFhjLqbhMEMtvPTHf9UYQXEbJ1jjHI7tKuaSAj+3vXa8hs7R0xq80iOHl 40SPwVMS/cZrmsM7P5Dk+URSSXRzBxsFrlE0xKUKJOyi7xlaj278u1/tuo44Po5i8nvu VW4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691004844; x=1691609644; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HwthBYp5vTxg58iDSn4M15H6vIlHS5/2yucv+b6GQN4=; b=gz34BGf1bgX97kbPFmJawaQzRg7jMMq7ZGDcFXTk4FISp+G+6TPtk1aSivmkJ5288O +3fZAzfjvH6S57SEVW/S2od3CgGEYvzvz7lLAfaNwtYuWrDwejDc5ZLMb0BZ6QhqiLts 9lihR3fsWJNEjXbXcMQ2PHSBUb3kjUOTHLxhUC6V6/QtFmwKlCHT9q3uC0fI6q4cwFFJ OPwt8DiMwDf76dxXL22X/lU2DUiNm2rznfoRyk9WwEiUVUHcSwtfmh3J6ED24olqT3NC UBQIL3RNUOuQBJm/8a8yGWIwdZ1IYb0CgQ/nUKN/zjiWbC9Bj58ekF5cDtQOnSDCzcMG 5esQ== X-Gm-Message-State: ABy/qLbKBtFHmlDAz8jaAMN5i+DlkcnpVSRAuAnBsnyRUJFJ4iM69hje mVoR0xuQDUfzKuvM8cQQWeaU61sZwFUYqtAOVQObHQ== X-Google-Smtp-Source: APBJJlGeJBHsyFu7muLO0suoSQp5jrfQQFIzh+90ukTXLSjnUUzNxR6ELzh2ZaRgtPRnlahs5uTJ6A== X-Received: by 2002:a05:6e02:924:b0:349:2498:ed90 with SMTP id o4-20020a056e02092400b003492498ed90mr7908293ilt.30.1691004843874; Wed, 02 Aug 2023 12:34:03 -0700 (PDT) Received: from murgatroyd (75-166-148-59.hlrn.qwest.net. [75.166.148.59]) by smtp.gmail.com with ESMTPSA id t13-20020a92ca8d000000b00348d652a6b4sm4711424ilo.48.2023.08.02.12.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:34:03 -0700 (PDT) From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH v2 3/6] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued, is_debug_type} References: <20230802095305.3668-1-tdevries@suse.de> <20230802095305.3668-4-tdevries@suse.de> X-Attribution: Tom Date: Wed, 02 Aug 2023 13:34:02 -0600 In-Reply-To: <20230802095305.3668-4-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 2 Aug 2023 11:53:02 +0200") Message-ID: <87jzuddys5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The two bitfields dwarf2_per_cu_data::queue and Tom> dwarf2_per_cu_data::is_debug_type share the same bitfield container. Tom> Fix this by making dwarf2_per_cu_data::queued a packed. Approved-By: Tom Tromey Tom