From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Subject: Re: [PATCH] gdbserver: extract code out of regcache's registers_to_string
Date: Tue, 20 Jun 2023 08:23:13 -0600 [thread overview]
Message-ID: <87jzvy2oxa.fsf@tromey.com> (raw)
In-Reply-To: <20230620124933.2792496-1-tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur via Gdb-patches's message of "Tue, 20 Jun 2023 14:49:33 +0200")
>>>>> "Tankut" == Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
Tankut> Extract out code from regcache's registers_to_string to dump a single
Tankut> register value to a string. Reuse the new method in
Tankut> 'collect_register_as_string' so that unavailable registers are dumped
Tankut> as 'xx...x' instead of arbitrary values.
Seems like a good idea.
Tankut> void
Tankut> collect_register_as_string (struct regcache *regcache, int n, char *buf)
Tankut> {
Tankut> - bin2hex (register_data (regcache, n), buf,
Tankut> - register_size (regcache->tdesc, n));
Tankut> + register_to_string (regcache, n, buf);
This is just a wrapper now, so I wonder if it could just be removed; or
if register_to_string should be renamed to collect_register_as_string.
Tom
next prev parent reply other threads:[~2023-06-20 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 12:49 Tankut Baris Aktemur
2023-06-20 14:23 ` Tom Tromey [this message]
2023-06-20 15:58 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzvy2oxa.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).