From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A31A63858C54 for ; Wed, 7 Jun 2023 14:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A31A63858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686148214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DZh3ylHjDHg2mzAc/WwxYTJhRbRAZjQ9BavWKhuRyF8=; b=H6RJky5jlGmtuJA+9eHoQrPmv0S2el2wK3GritB0SfiHZjpPgDqzi7x8pei6RnF7OFfIiK PG+6G9L5cUOyyHSBM95c97/+dhQ1UHUjN9vCWWFmwlj7hxi6+BE46xWDci7gmTo9xmZ0Wo 62vZrt9TJKXKH4MLF1RO8kvrezMhHR0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-guc29AsxOP6-8tn99FmTYg-1; Wed, 07 Jun 2023 10:30:01 -0400 X-MC-Unique: guc29AsxOP6-8tn99FmTYg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-30af00323b0so3374758f8f.2 for ; Wed, 07 Jun 2023 07:30:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686148200; x=1688740200; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DZh3ylHjDHg2mzAc/WwxYTJhRbRAZjQ9BavWKhuRyF8=; b=WyfiQWsU33kveLLW88e2VRXA0ttxWPFF1DqONFnngYiZh5k0pCJOq0UPUdhqDZvUkl tiTP1dEzAHy5DhZnfm11L09Hie64pyBr4BkGWWdHBrVDHwJHk6wTxLo8LEbkn9xMXG7o fYHd2K4o6iAFPoIvjpGdGBbZASHq4q0oXx4Wuz9C/ei3/GtFpdXNj9xyjOesquMSowuZ NkLt1epgdhAEr/oXFn5H6uQWM2WGZb/1IfNau4m/BuaCB1CovdZoFfvCoH6mzK7nzmh2 nqR93VG086ClE3To1mdiC8s3cciY2pDji633eqbzl4NgsyCbmuYfnlUKAw4kt7xi3+Ty y4vw== X-Gm-Message-State: AC+VfDxi1OMP0stkHL4zqFcTgB3zkJBavQkWIoccC9xAUIeKIOsWJtO4 Jo9vj9fQzktU4zkHSITH39KZHJxSCY8Gsu/qT/ojUWdew2+FeReSn1sYTRpGdty991usJWb9pC4 twzajwS41V7ySTd3itboCCA== X-Received: by 2002:a05:6000:41:b0:30a:b4e1:a89b with SMTP id k1-20020a056000004100b0030ab4e1a89bmr4412244wrx.67.1686148200135; Wed, 07 Jun 2023 07:30:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6lXsaEUSmdOeaRSlTQVsuJLh67J1dyKEQri0t9jIvP/Ge9RyUBEXVa5imbefXPfIsVUYOdtQ== X-Received: by 2002:a05:6000:41:b0:30a:b4e1:a89b with SMTP id k1-20020a056000004100b0030ab4e1a89bmr4412236wrx.67.1686148199867; Wed, 07 Jun 2023 07:29:59 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id c4-20020a5d4144000000b0030ade1b9400sm15690016wrq.30.2023.06.07.07.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 07:29:59 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv8 6/6] gdb: rename unwindonsignal to unwind-on-signal In-Reply-To: <834jnj4f7c.fsf@gnu.org> References: <834jnj4f7c.fsf@gnu.org> Date: Wed, 07 Jun 2023 15:29:58 +0100 Message-ID: <87jzwf1h21.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Eli Zaretskii writes: >> Cc: Andrew Burgess >> Date: Wed, 7 Jun 2023 11:01:18 +0100 >> From: Andrew Burgess via Gdb-patches >> >> We now have unwind-on-timeout and unwind-on-terminating-exception, and >> then the odd one out unwindonsignal. >> >> I'm not a great fan of these squashed together command names, so in >> this commit I propose renaming this to unwind-on-signal. >> >> Obviously I've added the hidden alias unwindonsignal so any existing >> GDB scripts will keep working. >> >> There's one test that I've extended to test the alias works, but in >> most of the other test scripts I've changed over to use the new name. >> >> The docs are updated to reference the new name. > > If the only changes in the documentation are mechanical renaming, can > I blindly approve the documentation part? Or would you prefer a real > review? Eli, Apologies, I forgot to add text to these emails to indicate that you have already approved all of the doc changes: [6/6] https://sourceware.org/pipermail/gdb-patches/2023-January/195874.html [5/6] https://sourceware.org/pipermail/gdb-patches/2023-January/195873.html [3/6] https://sourceware.org/pipermail/gdb-patches/2023-January/196462.html Sorry for wasting your time here. I'm going to go though and add your reviewed-by tag to each commit message now. I should have done this much sooner. Thanks, Andrew