From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 23BE53858D33 for ; Thu, 9 Mar 2023 14:24:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23BE53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id t1so1079955iln.8 for ; Thu, 09 Mar 2023 06:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678371878; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+/gK2n/MssC+j4PWkC4m9vG8mgsOgA+uys+8HPaJDZY=; b=jqd7arQC6GP5tdbGK7BUujrUNe9oe6ufGPbnIwdo4K/WMWFBIfiPGBY2YxKk4/OWzZ Hm7Ys268pO8DddPpp8irmEj/Ov7JZCRHR1abV2srntR1i0xPV9mU4NCyYWTPsNdMqNPM 15tqXNOrdGbi5F5Pa5yQ8FI0Zt+HEjXZzsQqvDTUI/XLc77y0LtAYQLHl0x2n6jlY/cf Ba3b/Q7no3B628R6B+baJmXh3Cptydv8ni2J1prmV1d18aLHI7w+duqcTywuHHRicgpK nKwM89ho55AtgQ3mq+qye3ixxtYdChuB2c4FAVJDkwCnxSESPHpqrpsmKSW8bNHS6qQe a4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678371878; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+/gK2n/MssC+j4PWkC4m9vG8mgsOgA+uys+8HPaJDZY=; b=ERHMtBBewwBn+zvO5g3m+qNEzyzbTDBYfAPm3fEIms7W3YcWFDQLqiTvk+j+RECq+F SnfnEzxOqs+GyKj7ppAw9UKfNCvAkdKlf/+t1Wg51MMxe5KDgBXz6U6mxGuCL9t4uXlP PhGLLR21sI3mSeFanLFeAw56JIZ09eGItG2b+AlN6CugpZVQjCUoMgY2I8/IjeYjgYxO 39bqh1z43lFHx6eg8M7XArbVgeTknS76KbOxMyqQimhDBGrPxibq2YOZ/S2zZSWri9cI 6ZihtulpTagGZA3t3zC2WWd5urZSjkdL6B77XsqjKwfzW39rHjSf+9GM4XdMSjEBI8tx QzIA== X-Gm-Message-State: AO0yUKWwf3iEjCLnpBwnQQmD9JCkqdlKdQK/cwh8USfa5swjqXZJjn0I yYMV7hliG/BvI4MPWuWt7DjJYw== X-Google-Smtp-Source: AK7set9ajNjSAXv4lukki2X666LxulEYRhjesjStrEn2vCmir6Z+qeKe78dtOs6+CHeokpJCLOSf1A== X-Received: by 2002:a05:6e02:1d07:b0:315:34a4:4e55 with SMTP id i7-20020a056e021d0700b0031534a44e55mr4566595ila.29.1678371878386; Thu, 09 Mar 2023 06:24:38 -0800 (PST) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id g11-20020a02bb8b000000b003e6fa127cc1sm6091829jan.63.2023.03.09.06.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 06:24:37 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Fix DAP stackTrace through frames without debuginfo References: <20230215194847.3805619-1-tromey@adacore.com> <874jqx7vux.fsf@tromey.com> X-Attribution: Tom Date: Thu, 09 Mar 2023 07:24:36 -0700 In-Reply-To: (Tom de Vries's message of "Thu, 9 Mar 2023 09:38:54 +0100") Message-ID: <87jzzqngt7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> I'm getting: Tom> ... Tom> {"request_seq": 5, "type": "response", "command": "stackTrace", Tom> "success": false, "message": "unhashable type: 'gdb.Frame'", "seq": Tom> 11}FAIL: gdb.dap/bt-nodebug.exp: backtrace success Tom> ... Tom> This is with python 3.6m. Thanks for the report. I guess a more recent Python somehow allows this. Anyway I think I can fix it by implementing tp_hash for this type. Tom