From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 493AB3858D37 for ; Fri, 3 Mar 2023 19:05:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 493AB3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 4155710041F44 for ; Fri, 3 Mar 2023 19:04:59 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id YAiBpGq9ANX2aYAiBpz6hS; Fri, 03 Mar 2023 19:04:59 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=640244db a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=6I5d2MoRAAAA:8 a=zstS-IiYAAAA:8 a=55r-ylkQy7srqkHxBfwA:9 a=IjZwj45LgO3ly-622nXo:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tqj7aG4EUjCXopyV7KGIADVTgo3u+tyiJKVCrFFOB24=; b=EaSzh/X7+4q8A0NC0wHT/PFr3S slI47mOLPtqy3mQKz8ygVEUeLigCtflGBAWia5l8J2ipONX1oex2ihYux7lI/F1W3szfJuw8nvNkn vtEwABtoyu+2UA7hhMMLn6vww; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:46720 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pYAiA-0049IB-Sg; Fri, 03 Mar 2023 12:04:58 -0700 From: Tom Tromey To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PING] [PATCH 0/2] Fix gdb.arch/amd64-gs_base.exp test on FreeBSD References: <20230217200219.87439-1-jhb@FreeBSD.org> <65c700e2-cfe9-6ffe-a850-cb6a5ada1663@FreeBSD.org> X-Attribution: Tom Date: Fri, 03 Mar 2023 12:04:56 -0700 In-Reply-To: <65c700e2-cfe9-6ffe-a850-cb6a5ada1663@FreeBSD.org> (John Baldwin's message of "Fri, 3 Mar 2023 09:58:38 -0800") Message-ID: <87jzzx8xlz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pYAiA-0049IB-Sg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:46720 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> On 2/17/23 12:02 PM, John Baldwin wrote: >> The gdb.arch/amd64-gs_base.exp test was failing on FreeBSD as it had >> some Linux-specific assumptions. While looking at this I also found >> that Linux/amd64 treats the fs_base and gs_base as "system" registers, >> but FreeBSD did not. I originally started by moving the logic from >> Linux/amd64 for these registers into i386_register_reggroup_p so it >> would be consistent across all OS ABIs, but I think it would be better >> to treat these registers as general registers instead which is what >> patch 2 does. >> John Baldwin (2): >> gdb.arch/amd64-gs_base.exp: Support non-Linux. >> amd64-linux-tdep: Don't treat fs_base and gs_base as system registers. >> gdb/amd64-linux-tdep.c | 4 +--- >> gdb/testsuite/gdb.arch/amd64-gs_base.exp | 10 ++++------ >> 2 files changed, 5 insertions(+), 9 deletions(-) John> Ping. These make sense to me. Thank you. Reviewed-By: Tom Tromey Tom