From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 08CA93858D32 for ; Sat, 11 Feb 2023 17:15:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08CA93858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676135738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sKj6B6OmI4T2f2lDw0L9xikdN5NFVjmctAB2u+zjut8=; b=aC8WL8L9IIhcLV7WXFUdrXp150Vgvpy2C2eXUGz1LsZHB9BE2Z9RF5Rg4JlPaHu3yE4wxN q+57dFV6p3rR11H2HtwScOEUEM5Y2dgmC5MrKRZODws2gY7T0x1p7VyZUMYNmwwvtbkFlI WgJkteGlaE/GTCnvfX4CxuCvFNMksqY= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-38-ec_fGGNoNxCgm42aORwC0w-1; Sat, 11 Feb 2023 12:15:37 -0500 X-MC-Unique: ec_fGGNoNxCgm42aORwC0w-1 Received: by mail-qv1-f70.google.com with SMTP id i7-20020a056214020700b004ffce246a2bso4814192qvt.3 for ; Sat, 11 Feb 2023 09:15:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sKj6B6OmI4T2f2lDw0L9xikdN5NFVjmctAB2u+zjut8=; b=AH967/I+FxkUtr1gkm/HiRlHRRZOVjG6YQ+p2yKXTrXIS8zmEQ5/a6v7kXzWOZllYo GHVp2UWfOUQ5r8B3fS763n7yLvdl/i976Id7Esi15EUOg4Z3GyLyJ6UxKPDgEpA6uV55 dtV8arkjw+XR1o835KvQ8PRUr2Ir6VKJy6HGXSUnYt3k1awY0K6qvrs6Wtg2EHJL5iSs barGinqGnECCFA/D65i4tOzShJ/s31LZmugDy9pqsuorx1EM/Sr7ePYqu5WasJzpE20s a/ilmYPRxKfZHiO4/hASIRluRt41WRaT+rAsVMpXUd7g7zVY0VBqxO3kiEW0Az2fMiH8 8BTw== X-Gm-Message-State: AO0yUKU5q4Tk2EIzV+x4y9JShqkfGTlDpLfJkAVUicR+IDZ5RKR3HCVp FfvYTL1OBhaDfAqELmDj1eNjGwJrfItKh0ZecrHY7afEPxuMlzDxYeOOb2RNkO3lQj3HYLdG32d EyMqm1Qmof6jNwmO3UL1adlKAJc8= X-Received: by 2002:a05:622a:1209:b0:3b6:3038:d4df with SMTP id y9-20020a05622a120900b003b63038d4dfmr32898385qtx.34.1676135736638; Sat, 11 Feb 2023 09:15:36 -0800 (PST) X-Google-Smtp-Source: AK7set9uWv5B4B1tNeqmpQrzxw8Hlk9GtxhuJTt8lFUwU9SzOwrqouMYPtdJNp3Z/pHIN6AhRW+Fjg== X-Received: by 2002:a05:622a:1209:b0:3b6:3038:d4df with SMTP id y9-20020a05622a120900b003b63038d4dfmr32898360qtx.34.1676135736422; Sat, 11 Feb 2023 09:15:36 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id u1-20020ac83d41000000b003b643951117sm5670270qtf.38.2023.02.11.09.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 09:15:36 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH] gdb: remove unnecessary 'dir' commands from gdb-gdb.gdb script In-Reply-To: <87y1p7ym2w.fsf@tromey.com> References: <51bcb8afd665fed00ce44e7eb33846d8444feea9.1675876331.git.aburgess@redhat.com> <87y1p7ym2w.fsf@tromey.com> Date: Sat, 11 Feb 2023 17:15:34 +0000 Message-ID: <87k00ounrd.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> While debugging GDB I used 'show directories' and spotted lots of > Andrew> entries that didn't make much sense. Here are all the entries that are > Andrew> in my directories list: > > Andrew> However... I'd like to propose that we instead remove all the extra > Andrew> directories completely. My hope is that, with more recent tools, the > Andrew> debug information should allow us to correctly find all of the source > Andrew> files without having to add any extra 'dir' entries. Obviously, > Andrew> commit 67f0714670383a does make me a little nervous, but the > Andrew> gdb-gdb.gdb script isn't something a non-maintainer will be using, so > Andrew> I think we can afford to be a little more aggressive here. If it > Andrew> turns out the 'dir' entries are needed then we can add them back, but > Andrew> actually document why they are needed. Plus, when we add them back we > Andrew> will use @abs_srcdir@ instead of @srcdir@. > > Makes sense to me. Thanks. I've pushed this. I'm sure people will shout if it turns out these were useful in someway. Thanks, Andrew