From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy2-pub.mail.unifiedlayer.com (qproxy2-pub.mail.unifiedlayer.com [69.89.16.161]) by sourceware.org (Postfix) with ESMTPS id 724BC3858D39 for ; Wed, 8 Feb 2023 17:44:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 724BC3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by qproxy2.mail.unifiedlayer.com (Postfix) with ESMTP id BCD09803010C for ; Wed, 8 Feb 2023 17:44:54 +0000 (UTC) Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id A9433100485FE for ; Wed, 8 Feb 2023 17:44:24 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id PoUapeSFmOscKPoUapEQoT; Wed, 08 Feb 2023 17:44:24 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Y5c9DjSN c=1 sm=1 tr=0 ts=63e3df78 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=jIsgDAGnn3ABe9szDTEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tZp0vWQK9lAdmgovs/f0ptHk8icZuR2ZncgCXUNxVOg=; b=Zjz6ZD2exe0Pm+tLfBd+/gIxXh GidbowD3BSlrLws5Ykv8p0O+HdGSJLY/eMgxpAk9GMq8W9ayUPVOTfDv15tjIdb/+YfwnEOqOcrZ7 +0r8xcxMJ1Hl6nIWdYYJuzzo1; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:43358 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pPoUZ-003JlG-QD; Wed, 08 Feb 2023 10:44:23 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Aaron Merey , simark@simark.ca Subject: Re: [PATCH] gdb/source: Fix open_source_file error handling References: <20230128033748.2839360-1-amerey@redhat.com> X-Attribution: Tom Date: Wed, 08 Feb 2023 10:44:21 -0700 In-Reply-To: <20230128033748.2839360-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Fri, 27 Jan 2023 22:37:48 -0500") Message-ID: <87k00s128a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pPoUZ-003JlG-QD X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:43358 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> Fix this by having open_source_file return a negative errno if it fails Aaron> to open a source file. Use this value to generate the error message Aaron> instead of errno. Also add new function throw_sys_errmsg for reporting Aaron> this value. I wonder if it's guaranteed somewhere that the errno values are always positive. Aaron> +/* Same as perror_with_name except that ERRCODE specifies the error Aaron> + instead of errno. */ Aaron> + Aaron> +void Aaron> +throw_sys_errmsg (const char *string, int errcode) IMO probably better to just add a parameter to perror_with_name that defaults to 0, meaning use errno. However, if you want to go this route, a function that always throws must be marked ATTRIBUTE_NORETURN. Tom