From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id B892D385B522 for ; Tue, 24 Jan 2023 15:25:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B892D385B522 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 2E6C110047A93 for ; Tue, 24 Jan 2023 15:25:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KLAipUtxXNX2aKLAipHtvy; Tue, 24 Jan 2023 15:25:16 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63cff85c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=n9Nvxce8AAAA:8 a=QD-nuYPzRCifSOeR9tUA:9 a=V4tbcg9hxeXQX3VEsxKP:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mKIdOQPTRAH9FJ9UJV2W6XK6sYcENv8tW71HwryIpTk=; b=eEH9GUo8ZlqwDYJJs0XNMYJgEv Zcp+AZFPDmnbYnS9M5Kp/lLTiCqmjZOg9FotI+3rQ2EOMfp6ee7GlRh4lm9iube6YZc/gl391g0hO FhYy9hTP6Z2VjurClC/Oyx8L2; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:53988 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKLAh-001P8p-K8; Tue, 24 Jan 2023 08:25:15 -0700 From: Tom Tromey To: Mark Wielaard Cc: gdb-patches@sourceware.org, Simon Marchi , Sam James Subject: Re: [PATCHv2] gdb: Ignore some stringop-overflow and restrict warnings on sparc References: <20230124004444.703203-1-mark@klomp.org> X-Attribution: Tom Date: Tue, 24 Jan 2023 08:25:13 -0700 In-Reply-To: <20230124004444.703203-1-mark@klomp.org> (Mark Wielaard's message of "Tue, 24 Jan 2023 01:44:44 +0100") Message-ID: <87k01cvtt2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKLAh-001P8p-K8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:53988 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Mark" == Mark Wielaard writes: Mark> For some reason g++ 12.2.1 on sparc produces a spurious warning for Mark> stringop-overread and restrict in fbsd-tdep.c for some memcpy calls. Mark> Add new DIAGNOSTIC_IGNORE_STRINGOP_OVERFLOW and Mark> DIAGNOSTIC_IGNORE_RESTRICT macro to suppress these warnings: Mark> gdb::byte_vector desc (sizeof (structsize) + buf->size ()); Mark> memcpy (desc.data (), &structsize, sizeof (structsize)); Mark> +#if defined (__sparc__) Mark> + /* g++ 12.2.1 on sparc seems confused about the vector buf sizes. */ Mark> + DIAGNOSTIC_PUSH Mark> + DIAGNOSTIC_IGNORE_STRINGOP_OVERFLOW Mark> + DIAGNOSTIC_IGNORE_RESTRICT Mark> +#endif Mark> memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); Mark> +#if defined (__sparc__) Mark> + DIAGNOSTIC_POP Mark> +#endif Is there any chance that std::copy or std::memmove would avoid the warning? It would be nice if this could be fixed without having to add a bunch of #if goo. However, if not, this is ok. Tom