From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 4BAFD3858C53 for ; Thu, 19 Jan 2023 13:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BAFD3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12a.google.com with SMTP id a9so682366ilb.0 for ; Thu, 19 Jan 2023 05:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vp+HQdJB8MM7VPGtYrb6GFmV3MfSBjhJK9xJ0Q01mjg=; b=JyCUVhOrb049r2gEanGbpIE7qSNHOyxWJ7NW1pMK69EhWNJvyb7xtG/67uowZrUoOQ FShsnxs7NnB9j7PTgYMsVvt2yqZd3+zEHr3/PnnlzCkIfU7h47wpDboe2K3617+bSHkx bRRkCmean6Elbuz6Lua6oOL9NLG+6DYowRzFKLqe5yAQfitCZqjKx1S/YPVOLbm4oWen 0BifNfrjn2IUqVqsuTWXbTHjzOwZN4DiozrRTEqjaeHn1eJsWy77aP4Z4B5/6y92hDp6 z5aRF2YP5m3VoIf//b7OKgTKwI4nYMlTERC6s6n48RJtLIqxiKoGxBGdjTZ0tFSHge0A Hg7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vp+HQdJB8MM7VPGtYrb6GFmV3MfSBjhJK9xJ0Q01mjg=; b=2w5VCixiEQKh589lk5UYyK05UfjbBDyQB2bQUmZsTQXMqKAGJnegjAHuIWMq40jkZ2 H+iMbPdz6ND2SFy4OiYdYCxcAwyc+K0m/8lymiylShQamjuj4QM/+FHRAjWPdx5XVibE 8Xb6fH+539hNMTf34h7wPnMHcBwa9rNSeo5CnBNGhG7MHu5x6TOYGAYjBr/iDX1oKRr9 Jo2hfObQglLjQKjpfKcsk/etMkxVgdnl57ZtLT80RiJaEtM3ETPEdHjizgIr/qTd3jOF hQavr2fmzB0zPwOOTutdEaqouLXFCm3RnUtBxGS5MiM0LzTwM1x+sUih6+TL+2TR4gaz WXpA== X-Gm-Message-State: AFqh2komYsnKemipaIca++eLHlV9Qn+BUHv+yCHOy6zXblCCty56nuLm hKko0WoVffi9g+dx1w0kGgutD4NOwox9v8Ho X-Google-Smtp-Source: AMrXdXtXznxKSnM+QFdvqdmrt6Nt3D0HjQOvV/EaSujBOzJU+ZJ2JLvjI74D6u6IRj1DyTnR94Nc1A== X-Received: by 2002:a92:2a07:0:b0:30f:4de:3276 with SMTP id r7-20020a922a07000000b0030f04de3276mr8514009ile.23.1674135394474; Thu, 19 Jan 2023 05:36:34 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id i5-20020a92c945000000b0030bfbc121a1sm10923888ilq.79.2023.01.19.05.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 05:36:33 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] Pass section index to start_compunit_symtab References: <20230118153025.342512-1-tromey@adacore.com> <20230118153025.342512-4-tromey@adacore.com> <56ff147d-d09f-2093-efac-50b1eee555d0@simark.ca> <87pmbbzekb.fsf@tromey.com> <2ae94116-fb85-ee8b-8772-4cf176a45c11@simark.ca> X-Attribution: Tom Date: Thu, 19 Jan 2023 06:36:32 -0700 In-Reply-To: <2ae94116-fb85-ee8b-8772-4cf176a45c11@simark.ca> (Simon Marchi's message of "Wed, 18 Jan 2023 17:06:57 -0500") Message-ID: <87k01izlwf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> I'm curious to know why we have to store that and we can't always use Simon> SECT_OFF_TEXT, but I guess that will come with the following patches. >> I suspect this is dead code, I just didn't change it in this series. >> I could though if you'd prefer. Simon> I suppose that if it's indeed always the text section that is passed, it Simon> would be easy to spot. I've updated patch #3 to just remove the section index from end_compunit_symtab, and I've added a new patch to the series to remove compunit_symtab::m_block_line_section. Tom