From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 581A13858D1E for ; Mon, 9 Jan 2023 16:45:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 581A13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd35.google.com with SMTP id h6so4765923iof.9 for ; Mon, 09 Jan 2023 08:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=B0nkdyBnHDmw0blMDLJFfrSz1CBB0P+s3jYCmwLth08=; b=Vfc3Fv4/hPdM6uwCNTJl4AXuvDYZWQUIjz1zFvNEwlMKpyuW4pw1B24/nSAfTQ53KE 2Uq1v6YdgRma/UOvKvwWO63hQJ2Hl42Tq3mxaCWUzN/tx6EQ8iQpGihR8JYtzUSXL/tT Q7jf1CRFEUnz7i5D3zXUtyxKG9v9v0FMXduzIlpZDgwfwnPyhp+377ufL6RJgTnmi4h5 uL9dWszbL05crC/M/UI13YmRmD2cduaYCNHQlfcPsZ3jFJ4DOhoN1fb8ou8DPBEvGGHP bXYwcl4Fh4OFWTJa2ibwS78onq2TCQbeUcgnNQOy/fR+t1+MPjUG6evYPNMIxwBgu1OY +fTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B0nkdyBnHDmw0blMDLJFfrSz1CBB0P+s3jYCmwLth08=; b=aVt9GsTtTUk9HgbrbWrQrqCiJJlemlXeRrMjxMGRVji3/HiSNgQmWnF8iqFpVB3EdU ROrqnxslJihv3ZRdogUavTRk4IJr/lTlAbv33HXW1SXL1Q3Of20QYi16Ig3I/iwu8Tbj aKoUU/hWXlg4ZBucwh75iBK65s7Kc3nB0aT8GcxOIIluIrmPqPR4Y5BFkbEmXn+YXZT7 La4hSl6J7MROlOL724Jo69VLcNF8pr3UAOdR8C9dBoBntqMAxqMxtC1vDjsXHXI8j+YM bQN08HdAY+WqtZySIqe0HP1sz/aKkpndMeLyVDa+GkDJLMMXvCt/bQwoztc3ZVX5gYoJ SrbQ== X-Gm-Message-State: AFqh2kpUHLJsX/vzDUVCOlcE7naDqqK8ubvmSuSfM/Ac1XVHVnUb8MyW ZXhtITsJeTArIe7IyTdWgqxQPjNXO+CWQnOY X-Google-Smtp-Source: AMrXdXsW4BGbmWSEvJB70ht1l42TuGA+TNbcR7ZumloZ2C4CRh7RMD3nC7F7rNXJfwog/4mdzsTXrw== X-Received: by 2002:a6b:770d:0:b0:6e2:d23a:6296 with SMTP id n13-20020a6b770d000000b006e2d23a6296mr43552903iom.20.1673282719614; Mon, 09 Jan 2023 08:45:19 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id cl4-20020a0566383d0400b00369a91d1bd4sm2866631jab.138.2023.01.09.08.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 08:45:19 -0800 (PST) From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey via Gdb-patches , Andrew Burgess , Tom Tromey Subject: Re: [PATCH 2/4] Don't erase empty indices in DWARF reader References: <20221215190759.2494095-1-tromey@adacore.com> <20221215190759.2494095-3-tromey@adacore.com> <878rj3zbtv.fsf@redhat.com> <87tu1rl3rh.fsf@tromey.com> X-Attribution: Tom Date: Mon, 09 Jan 2023 09:45:18 -0700 In-Reply-To: (Joel Brobecker's message of "Sat, 7 Jan 2023 15:24:09 +0400") Message-ID: <87k01vac81.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Joel> If we believe the code is dead, let's drop it. Joel> Maybe Andrew's assert suggestion could be helpful, although perhaps Joel> a complaint might be a better compromise in this case, as I would say Joel> a violation of this expectation would still mean a usable debugging Joel> experience for the user, so let's not break things with an assert? I think a complaint would be incorrect here. Normally complaints are reserved for bad debug information, but this is just an internal aspect of the code -- the contract of parallel-for. I think it may be best to just drop this patch and leave the current code in place. It doesn't do anything, but on the other hand, this seems to be non-obvious, so it may serve a useful assurance purpose. Tom