From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id D28D63858C39 for ; Thu, 5 Jan 2023 20:05:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D28D63858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 5701E100483BD for ; Thu, 5 Jan 2023 20:05:32 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DWUWp3OhN2CCnDWUWpCJor; Thu, 05 Jan 2023 20:05:32 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ds2TREz+ c=1 sm=1 tr=0 ts=63b72d8c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=Dgmiq1G4tX7zXAYHGDoA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fk3jqmItj+N6Ih30jrw9Xt7RspMdLpKkFIaK0bzi3IQ=; b=t1bJDkjmCHK1yITdmKMQJKBcFy x0jDBnA34woDlG3g+CiGfwow2CwhvZ2JxefRDXfonKOMYrErdvzbMagh0fZNL2doV5L2hosX2ZriO pClbAsUMS41ElFHFFxl+aK9bD; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:58322 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDWUV-003xtV-Ux; Thu, 05 Jan 2023 13:05:32 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Andrew Burgess Subject: Re: [PATCH] gdbsupport: fix scoped_debug_start_end's move constructor References: <20230104212242.545914-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 05 Jan 2023 13:05:29 -0700 In-Reply-To: (Simon Marchi via Gdb-patches's message of "Wed, 4 Jan 2023 17:01:16 -0500") Message-ID: <87k020d9x2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pDWUV-003xtV-Ux X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:58322 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> + scoped_debug_start_end (scoped_debug_start_end &&other) >> + : m_debug_enabled (other.m_debug_enabled), >> + m_module (other.m_module), >> + m_func (other.m_func), >> + m_end_prefix (other.m_end_prefix), >> + m_msg (other.m_msg), Simon> Just found this nit... not that it changes anything (because this ctor Simon> isn't called in practice), but we should std::move m_msg. I'll change Simon> it locally. I think it's also fine to just leave it as-is. Simon> Well, we could std::move all fields, but it would be a bit verbose. If we think we may need this kind of behavior again, one way would be a sort of "move token" object that wraps a bool, and that sets the bool on construction and clears it on move. Then scoped_debug_start_end could just use the default move constructor again, and check the token's value in its destructor. Probably overkill for just the one case. I think your patch is ok. Tom