From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id E41BA3854572 for ; Mon, 28 Nov 2022 20:55:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E41BA3854572 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id D1F3D101C6D43 for ; Mon, 28 Nov 2022 20:29:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id zklDoHUY5OBo0zklDoLe1a; Mon, 28 Nov 2022 20:29:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QrGbYX+d c=1 sm=1 tr=0 ts=63851a3f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=EIxdK6fd6oZjYogHtVYA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1+NT8vpo3VAh73//j8FcwQ2BCKXzYPII6VP2WS/XHus=; b=eun7PDEZAH7R8bB7/QD0VHMNXV L3vTO27wWnEeDDF7brUksPstwiamilz0YYJWNF14XYdz5RQlJ6wkypHzalNxmLKe0Qc/PQc/odmYW MKIVDy7MXVhmeGSRoLcFud7dY; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56898 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ozklD-002Xne-Fv; Mon, 28 Nov 2022 13:29:51 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi Subject: Re: [PATCH 2/3] Don't let tee_file own a stream References: <20221117182904.1291713-1-tromey@adacore.com> <20221117182904.1291713-3-tromey@adacore.com> X-Attribution: Tom Date: Mon, 28 Nov 2022 13:29:49 -0700 In-Reply-To: (Simon Marchi via Gdb-patches's message of "Mon, 28 Nov 2022 14:18:28 -0500") Message-ID: <87k03eom9u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ozklD-002Xne-Fv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56898 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> + mi->saved_tee_to_delete = nullptr; Simon> Should the two _to_delete ones be ui_file_ups? It would be better. I'll add on a patch to do this. Simon> Otherwise, everything related to logging / redirection confuse me, so I Simon> can't really comment on the change itself. It's a real mess. Tom