From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 2BD523854551 for ; Fri, 18 Nov 2022 17:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2BD523854551 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 91A2610044A72 for ; Fri, 18 Nov 2022 17:29:59 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id w5BfobILmhil5w5BfotaXK; Fri, 18 Nov 2022 17:29:59 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Qo6bYX+d c=1 sm=1 tr=0 ts=6377c117 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=g0tBCwu04fbL9hP3-WEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c9OoQmsU204XdaJio+8EovnFZM8+aQwwCiRAQwqmGIU=; b=HzjjYuHEtlTSaytyyv2efS7X/6 D/qxUFJbaeOlsf+YTEvnDvGJKKQGP3wJ1uPASm675eUIs1K7y+SQSLIQRp1U0gVUXm8i1/8UKcTnR ZBU/D9AlxfU2XIsggZJhklobs; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56874 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ow5Bf-004988-9R; Fri, 18 Nov 2022 10:29:59 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCHv3 4/7] gdb: remove the pop_all_targets (and friends) global functions References: <4b85a8b4e635dafa1ca18e3602ba04669876b6b4.1668789658.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 18 Nov 2022 10:29:57 -0700 In-Reply-To: <4b85a8b4e635dafa1ca18e3602ba04669876b6b4.1668789658.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 18 Nov 2022 16:42:55 +0000") Message-ID: <87k03sqiga.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ow5Bf-004988-9R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56874 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> This commit removes the global functions pop_all_targets, Andrew> pop_all_targets_above, and pop_all_targets_at_and_above, and makes Andrew> them methods on the inferior class. This seems like an improvement to me. Andrew> +void inferior::unpush_target_and_assert (struct target_ops *target) There should be a newline after 'void'; there's a few instances of this. Tom