From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id D7830395BC5F for ; Wed, 16 Nov 2022 17:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7830395BC5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 495C1100455B0 for ; Wed, 16 Nov 2022 17:20:15 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id vM58okhvq4zMWvM58oPNU0; Wed, 16 Nov 2022 17:20:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=E4sIGYRl c=1 sm=1 tr=0 ts=63751bcf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=myV9K86zJ2vQf11iMX0A:9 a=fDZVmK1S32wA:10:demote_hacked_domain_1 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YxKcb8wHedROPEEe+UrUYs4NfjvfGeYpwAd3qX9r8A4=; b=QBZZKGzXR7teA2msg1+c2d1KzG Mn04SpVLhBfTm4nLqkjWwS37bGx2MSoMhuqKQk7OpSyXwIFUCOLaVyMzbBfU0rY9lWZlitJfue7QX GZZIW7IfHcOXJ4h3au1PL3Al2; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56854 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovM58-003OMD-Oj; Wed, 16 Nov 2022 10:20:14 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 00/14] Remove all uses of 'then' keyword from the testsuite References: X-Attribution: Tom Date: Wed, 16 Nov 2022 10:20:11 -0700 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Tue, 15 Nov 2022 10:42:17 +0000") Message-ID: <87k03uu88k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ovM58-003OMD-Oj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56854 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> It was pointed out to me (off-list) that in this patch: Andrew> https://sourceware.org/pipermail/gdb-patches/2022-November/193744.html Andrew> I had made use of TCL's 'then' keyword, which apparently is not the Andrew> preferred way to write if statements these days, at least, not for Andrew> single line conditions. And it certainly seems that NOT using 'then' Andrew> is more common in the GDB testsuite. I always liked the "noise" keywords in Tcl, but I think it's fine to remove the "then"s. I'd prefer we keep "else", though, even though it isn't strictly required. Especially for long "if"s I think the "else" adds some clarity. So, ok from me. Thank you. Tom