Re: [PATCH] gdb: add UTF16/UTF32 target charsets in phony_iconv

[Tom Tromey <tom@tromey.com>]

>>>>> "Patrick" == Patrick Monnerat via Gdb-patches <gdb-patches@sourceware.org> writes:

Patrick> Function phony_iconv is substituted to the system-supplied iconv on
Patrick> platforms where the latter is deficient.

I sort of hate to improve the phony iconv, but I get why one might want
to.

Patrick> Conditonal statements decide when the substitution occurs. This
Patrick> currently enables it for mingw (wchar_t is not UTF-32) even when the
Patrick> system-supplied iconv is suitable for gdb use.

I don't recall the outcome from this, but is there no way to improve gdb
to use this iconv?  If it truly works well enough then it seems like it
would be the better approach.

Patrick> +  static struct

This can also be const.

Patrick> +#if WORDS_BIGENDIAN
Patrick> +      {	"wchar_t", (sizeof (gdb_wchar_t) - 1) | TOKEN_BIGENDIAN },
Patrick> +#else
Patrick> +      {	"wchar_t",  (sizeof (gdb_wchar_t) - 1) },
Patrick> +#endif

This has tabs before the strings but there's no need.

Patrick> +      { NULL, -1 }
... 
Patrick> +  for (auto p = encodings; p->name; p++)
Patrick> +    if (strcmp (encoding, p->name) == 0)
Patrick> +      return p->token;

You can drop the trailing null entry and just do:

    for (auto p : encodings)

Patrick> +  if(token & ~((TOKEN_MASK << TOKEN_BITS) | TOKEN_MASK))

Missing space after the "if".

Patrick> +  maxval = 1UL << (7 * tosize);	/* Split shift to avoid count overflow. */

gdb doesn't generally use comments at the end of the line.

Tom