From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 773D73858D37 for ; Wed, 5 Oct 2022 11:39:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 773D73858D37 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-543-Rol9SC9IPQy_UxF4sSGhQQ-1; Wed, 05 Oct 2022 07:39:00 -0400 X-MC-Unique: Rol9SC9IPQy_UxF4sSGhQQ-1 Received: by mail-wm1-f70.google.com with SMTP id i82-20020a1c3b55000000b003bf72acab9bso286468wma.1 for ; Wed, 05 Oct 2022 04:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mz7iiHH3IXW4FVcobBnDr5SnI+Www/2V+MSvV2FSi6M=; b=M6+cbpfZZR5o7ut9On/Zty46+keXMoXsphNchWLgTqu1In1GNJu6jSDT5I5W0T4eDl PWf2IkELZ/8H/y7ojxohdYlK6PXXi+x2PjWn6C2Fb9bDv+T3cWsn1ErSLk9ExZ+QA/6x 4RiF1uOdDxLpSyMQd0iKSVYjG32lnSBf/YYD3pE643BX1DRF7md4V0ihc4mJn0u/EZYn tMt4wL1fXx0Z2493Qntpe8Wfy+bodLr9wF/ACLfWHG5AwlHteabPxnTcsIZmMON6G61M yr8Nv4roSc2wtNPjNIs15PKjv9DDMR4p1QBzvfGbpzk1qptkT7g/cME3f//T+iAaY2ZE 6Ebw== X-Gm-Message-State: ACrzQf2Z1379X7MqobN8ANtmBsIamqhZxyIvtPkHDdFrIyqJyCbltXL3 c5IhscD1NsWuM5T04Y3EJBBPgaf4kficT4iFNQat3kvScTnzyL88KRVrG5h5kiADKy+poe9j4YZ yyr/52Ar2kvrP0tITz82u5A== X-Received: by 2002:a05:6000:69b:b0:22e:36aa:5f1 with SMTP id bo27-20020a056000069b00b0022e36aa05f1mr9986828wrb.430.1664969938444; Wed, 05 Oct 2022 04:38:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6+IrOMoisySKkrjTJkvvdikYflkmHoE+Q3rM0E7SmlD3h+PAzoDlrruw3DMqHHsmA3wB4TzQ== X-Received: by 2002:a05:6000:69b:b0:22e:36aa:5f1 with SMTP id bo27-20020a056000069b00b0022e36aa05f1mr9986808wrb.430.1664969938191; Wed, 05 Oct 2022 04:38:58 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id s15-20020a5d424f000000b0022afe4fb459sm4330447wrr.51.2022.10.05.04.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 04:38:57 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI , Tsukasa OI , Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] sim: Make WITH_{TRACE,PROFILE}-based macros bool In-Reply-To: References: Date: Wed, 05 Oct 2022 12:38:57 +0100 Message-ID: <87k05efqjy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2022 11:39:09 -0000 Tsukasa OI writes: > Clang generates a warning if an ambiguous expression (possibly a bitwise > operation (& or |) but a logical operator (&& or ||) is used) is detected. > Because of the default configuration ("-Werror"), it causes a build failure. > > This is caused by predicate macros that use (base_variable & flag). > Clang considers them as regular integer values (not boolean) and > generates that warning. > > This commit makes Clang to think those predicate macros to be boolean. > > sim/ChangeLog: > > * common/sim-profile.h (WITH_PROFILE_INSN_P, WITH_PROFILE_MEMORY_P, > WITH_PROFILE_MODEL_P, WITH_PROFILE_SCACHE_P, WITH_PROFILE_PC_P, > WITH_PROFILE_CORE_P): Make predicate macros boolean. > * common/sim-trace.h (WITH_TRACE_P, WITH_TRACE_ANY_P): Likewise. > --- > sim/common/sim-profile.h | 12 ++++++------ > sim/common/sim-trace.h | 4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sim/common/sim-profile.h b/sim/common/sim-profile.h > index 61d5039e10d..acf0f7d74e2 100644 > --- a/sim/common/sim-profile.h > +++ b/sim/common/sim-profile.h > @@ -87,12 +87,12 @@ SIM_RC sim_profile_set_option (SIM_DESC sd_, const char *name_, int idx_, > #define PROFILE_core (1 << PROFILE_CORE_IDX) > > /* Preprocessor macros to simplify tests of WITH_PROFILE. */ > -#define WITH_PROFILE_INSN_P (WITH_PROFILE & PROFILE_insn) > -#define WITH_PROFILE_MEMORY_P (WITH_PROFILE & PROFILE_memory) > -#define WITH_PROFILE_MODEL_P (WITH_PROFILE & PROFILE_model) > -#define WITH_PROFILE_SCACHE_P (WITH_PROFILE & PROFILE_scache) > -#define WITH_PROFILE_PC_P (WITH_PROFILE & PROFILE_pc) > -#define WITH_PROFILE_CORE_P (WITH_PROFILE & PROFILE_core) > +#define WITH_PROFILE_INSN_P (!!(WITH_PROFILE & PROFILE_insn)) > +#define WITH_PROFILE_MEMORY_P (!!(WITH_PROFILE & PROFILE_memory)) > +#define WITH_PROFILE_MODEL_P (!!(WITH_PROFILE & PROFILE_model)) > +#define WITH_PROFILE_SCACHE_P (!!(WITH_PROFILE & PROFILE_scache)) > +#define WITH_PROFILE_PC_P (!!(WITH_PROFILE & PROFILE_pc)) > +#define WITH_PROFILE_CORE_P (!!(WITH_PROFILE & PROFILE_core)) Rather than using this '!!' trick, which I'm really not a fan of, could we just do: #define WITH_PROFILE_CORE_P ((WITH_PROFILE & PROFILE_core) != 0) I feel this is an accurate representation of the question we're actually asking. Thanks, Andrew > > /* If MAX_TARGET_MODES isn't defined, we can't do memory profiling. > ??? It is intended that this is a temporary occurrence. Normally > diff --git a/sim/common/sim-trace.h b/sim/common/sim-trace.h > index d08810d9fcc..bc3e690a4cc 100644 > --- a/sim/common/sim-trace.h > +++ b/sim/common/sim-trace.h > @@ -125,10 +125,10 @@ enum { > #define TRACE_debug (1 << TRACE_DEBUG_IDX) > > /* Return non-zero if tracing of idx is enabled (compiled in). */ > -#define WITH_TRACE_P(idx) (WITH_TRACE & (1 << idx)) > +#define WITH_TRACE_P(idx) (!!(WITH_TRACE & (1 << idx))) > > /* Preprocessor macros to simplify tests of WITH_TRACE. */ > -#define WITH_TRACE_ANY_P (WITH_TRACE) > +#define WITH_TRACE_ANY_P (!!(WITH_TRACE)) > #define WITH_TRACE_INSN_P WITH_TRACE_P (TRACE_INSN_IDX) > #define WITH_TRACE_DISASM_P WITH_TRACE_P (TRACE_DISASM_IDX) > #define WITH_TRACE_DECODE_P WITH_TRACE_P (TRACE_DECODE_IDX) > -- > 2.34.1