From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id 043F63858C52 for ; Fri, 23 Sep 2022 13:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 043F63858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 2D90F80264E8 for ; Fri, 23 Sep 2022 13:52:14 +0000 (UTC) Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id F38861003FA3E for ; Fri, 23 Sep 2022 13:50:37 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id bj4foBlguaT2Rbj4for4Ch; Fri, 23 Sep 2022 13:50:37 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BO52EHcG c=1 sm=1 tr=0 ts=632db9ad a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=3lhGuGds8MQg58ZXSMcA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=opy+QJnSz0Zk6CRqrTj/HcWkipFC9GdSje2qby+95Z8=; b=ZmZS0Jt3hKb0OaAYTKoMf9Ookm ov80Hp25D+jl5mNlCuqBxzEjkqGrMv9QhZr4UZi0ordeyKB+xr6/3HKMf1n/Tx8MupHbs/OVIfJmM v7vlYzLurrHKkRAQA30YS4H75; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56566 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1obj4e-001aR5-I4; Fri, 23 Sep 2022 07:50:36 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb/testsuite/tui: start GDB with "set filename-display basename" References: <20220922160215.742183-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 23 Sep 2022 07:50:31 -0600 In-Reply-To: <20220922160215.742183-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 22 Sep 2022 12:02:15 -0400") Message-ID: <87k05u19p4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1obj4e-001aR5-I4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56566 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 13:52:28 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> And that causes `wait_for` to think the "step" command is complete. Simon> This is wrong, as the prompt at line 17 isn't the prompt drawn after the Simon> completion of the "step" command. The subsequent tests now run with a Simon> partially updated screen (what is shown above) and obviously fail. Simon> The ideal way to fix this would be for `wait_for` to be smarter, to Simon> avoid it confusing the different prompts drawn. This is actually ridiculously hard. Not being able to solve this is why we added the refresh-counting hack for TUI testing. Simon> Doing this happens to fix my failures and makes my CI happy (which in Simon> turns makes me happy). To be clear, I understand that this does not fix Simon> the root issue of `proc wait_for` being confused. However, it makes TUI Simon> test runs be more similar for everyone, such that there's less chance of Simon> TUI tests randomly failing for somebody. It seems like an improvement to me. Simon> Note that there are other reasons why TUI tests could vary, like Simon> different curses library versions taking different re-drawing decisions. Simon> However, I think my change is a good step towards more stable test Simon> results. Indeed, I think this has happened already. Anyway the patch looks good to me. Tom