From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7F472385C300 for ; Mon, 12 Sep 2022 10:49:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F472385C300 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-281-bk3w8_iTNim78mC_DYkXdg-1; Mon, 12 Sep 2022 06:49:18 -0400 X-MC-Unique: bk3w8_iTNim78mC_DYkXdg-1 Received: by mail-wm1-f70.google.com with SMTP id t14-20020a1c770e000000b003b4856a6ecaso1320308wmi.2 for ; Mon, 12 Sep 2022 03:49:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=qOYAQwCNIWMIT5f983tcKA1O0Ft79nlV6NyZdFE03hs=; b=IcDs9uLixpaZdSAhJJ3eYf99UmxkRuI7H5ELF5fdo7RePO2vz8Nlf6Bgp4g/U+Q6gR Mqdlabu6Sq+vjfcPCly5bAsvrWGbhJoCBG95zWj5uy+KJQ+A7F/R9fS9EG8xYcfhOyHj UcWBcTgFCMgB4qEmu/Mo9jVavMgYQMlzbQhNjB0euVdNmfxjDAPM1zul9k4GTeUEKj4Q g3+IUPanajk1FcUlNo+aPaPo5d51eL6D0hqWcuPTDK0EmYbQ4PzG1SHSKkCuW4OEmScJ DKmNBNr3GKZqb8ybr+vSAHTslJ2yQM1mSwWFcoXsUVPqu2L/3basah4rj2ccBXfd28m1 IYKg== X-Gm-Message-State: ACgBeo2zo40Qj/3b/COhNhMB1eDWv4Cvz7ahVt3qL32fr0cCEN0SmDYj KYXYdeWD31k04UoOKV8xqAOiNfc9IL1B3dz8zLjUKKmUdnhpMkHhXrJERRZixZtCIiD4yaxLjqg iqk8KF+46g43GL+qjsAkELQ== X-Received: by 2002:a05:600c:1906:b0:3a5:fe9c:4dcf with SMTP id j6-20020a05600c190600b003a5fe9c4dcfmr13720092wmq.118.1662979756906; Mon, 12 Sep 2022 03:49:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR5xx1+M1kOsF5kximdOm2BWGdXRLQ4XKVRtIDHxdqeAm70P5latej36GK9TaD/N3fntHWvbqg== X-Received: by 2002:a05:600c:1906:b0:3a5:fe9c:4dcf with SMTP id j6-20020a05600c190600b003a5fe9c4dcfmr13720080wmq.118.1662979756741; Mon, 12 Sep 2022 03:49:16 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id p15-20020a5d48cf000000b00226dedf1ab7sm7157381wrs.76.2022.09.12.03.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 03:49:16 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang In-Reply-To: <20220720194441.168906-10-blarsen@redhat.com> References: <20220720194441.168906-1-blarsen@redhat.com> <20220720194441.168906-10-blarsen@redhat.com> Date: Mon, 12 Sep 2022 11:49:15 +0100 Message-ID: <87k068lvf8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 10:49:21 -0000 Bruno Larsen via Gdb-patches writes: > clang doesn't add encoding to the name of complex variables, only says > that the type name is complex, making the relevant tests fail. > This patch adds the xfails to the tests that expect the variable name to > include it. > --- > gdb/testsuite/gdb.base/complex-parts.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/complex-parts.exp b/gdb/testsuite/gdb.base/complex-parts.exp > index e67fd482268..7fa94c72cd4 100644 > --- a/gdb/testsuite/gdb.base/complex-parts.exp > +++ b/gdb/testsuite/gdb.base/complex-parts.exp > @@ -30,8 +30,13 @@ gdb_test "p z1" " = 1.5 \\+ 4.5i" > gdb_test "p z2" " = 2.5 \\+ -5.5i" > gdb_test "p z3" " = 3.5 \\+ 6.5i" > > +# The following 3 tests are broken for Clang. > +# More info at https://github.com/llvm/llvm-project/issues/52996. > +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } > gdb_test "ptype z1" " = complex double" > +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } > gdb_test "ptype z2" " = complex float" > +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } > gdb_test "ptype z3" " = complex long double" > > with_test_prefix "double imaginary" { LGTM. Please go ahead and apply. Thanks, Andrew