From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 10DB13858D28 for ; Mon, 18 Jul 2022 16:49:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 10DB13858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id A273110047E2E for ; Mon, 18 Jul 2022 16:49:28 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DTvzo790iWBOVDTw0olFVZ; Mon, 18 Jul 2022 16:49:28 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=cpReL30i c=1 sm=1 tr=0 ts=62d58f18 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=SK5aXy0dqlO9OxmRlJEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zjFk56NVuyPiTt6AyQgBB2joPy/l76CiS/PcRNXhO4c=; b=lIkCTsHKZRn5VlfzYBKa64o5Zl HFfs0/6a+q+fss3gcWMsMjBeHhk76/11D702Yf7jblx05eKW12WBegnpaaWhxGvSjoOeC+jU+Zhn7 wCtODNXzJy5LUk1jpRmq4m5K+; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56156 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oDTvz-000plf-46; Mon, 18 Jul 2022 10:49:27 -0600 From: Tom Tromey To: Kevin Buettner via Gdb-patches Subject: Re: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-9-markus.t.metzger@intel.com> <20220624102644.52901c2e@f35-zws-1> X-Attribution: Tom Date: Mon, 18 Jul 2022 10:49:25 -0600 In-Reply-To: <20220624102644.52901c2e@f35-zws-1> (Kevin Buettner via Gdb-patches's message of "Fri, 24 Jun 2022 10:26:44 -0700") Message-ID: <87k08al622.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oDTvz-000plf-46 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56156 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 16:49:43 -0000 >> When searching for standard exceptions for Ada, we lookup the minimal >> symbol of each exception. With linker namespaces there can be multiple >> instances in different namespaces. Collect them all. >> --- >> gdb/ada-lang.c | 30 +++++++++++++++++++++++------- >> 1 file changed, 23 insertions(+), 7 deletions(-) Kevin> I'm not an Ada expert, but this seems reasonable. This seems fine to me as well. Tom