From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id EE7673857362 for ; Mon, 20 Jun 2022 15:10:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE7673857362 Received: by mail-il1-x129.google.com with SMTP id h5so5428114ili.3 for ; Mon, 20 Jun 2022 08:10:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HRF9qNblEds8S+igZxwjWTEqKnZDPAGnOC+vtbZRfm4=; b=3wZtHA1604OVbKOYuD6wZZcXaGaJwTtimZmEe9zXvmRdyZD09lCIK6HdMiljBZiHkh MQhu6vdd7geARqsIcfvBHz/Dv7EWA9c06TQ6KG+FKBf7feJsAxvrSHQo0bOPXUz8Q15G HlwHmBjbsLff97GY1HYl3W9GDRGyAUi592JHz/dpS5RbeA7RL3l+buEQz8Z3Juq+syI2 AN/xLB75X8+YK8sHzzNdMx6XmQ0zW2ApW1slJ31VkCrQchuKLse2dVjJwLx6sodZQTtn 697L6Id3gvDEWwZabYtEJnx8AH6mtLVssWH7/hhIKZJAum0MoAOsAsiVod5KSRGXq9BL r/6g== X-Gm-Message-State: AJIora/akSC3zkyth6ZZwM5urhjvlyQ1RCQ5HwPwSqMUvgcQi6wtdyy+ HQJyAg6hM3RJto/HfqQPtgx5RNQzqKsUvg== X-Google-Smtp-Source: AGRyM1tnz/SxT8oWLEiYu9JpEjg3pjweR2lQxVxMDCEZIGc4tFWjNF58C3JBdwbLt0P4FFx995GlRw== X-Received: by 2002:a05:6e02:174c:b0:2d3:c1e2:36fe with SMTP id y12-20020a056e02174c00b002d3c1e236femr14077621ill.121.1655737855221; Mon, 20 Jun 2022 08:10:55 -0700 (PDT) Received: from murgatroyd (71-211-187-180.hlrn.qwest.net. [71.211.187.180]) by smtp.gmail.com with ESMTPSA id l1-20020a02cce1000000b0032e798bc927sm6055423jaq.133.2022.06.20.08.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 08:10:54 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Move finish_print out of value_print_options References: <20220606161156.3073171-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 20 Jun 2022 09:10:53 -0600 In-Reply-To: <20220606161156.3073171-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Mon, 6 Jun 2022 10:11:56 -0600") Message-ID: <87k09bwete.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2022 15:10:59 -0000 >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> 'finish_print' does not really belong in value_print_options -- this Tom> is consulted only when deciding whether or not to print a value, and Tom> never during the course of printing. This patch removes it from the Tom> structure and makes it a static global in infcmd.c instead. I'm checking this in. Tom