From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1585B382B261 for ; Mon, 13 Jun 2022 12:13:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1585B382B261 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-bjwkIWwmOxaR_B7uF3-2Rw-1; Mon, 13 Jun 2022 08:13:15 -0400 X-MC-Unique: bjwkIWwmOxaR_B7uF3-2Rw-1 Received: by mail-qv1-f72.google.com with SMTP id x17-20020a0cfe11000000b004645917e45cso3765614qvr.4 for ; Mon, 13 Jun 2022 05:13:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=gCjWePZbSZGIziIRp8bk55sN546YgHcKXJI28Rkjt10=; b=5sz8NpPZ10SUx8C1YWd/aERAhNbrJ6QFP8O9r2HTj6fNaoTJbjXrzeLp4FPWokogj0 Jg4yeB8iCZ468iZyY4gwIEJSKj+OMbe253OQfWBON274iTrTXvOUJnPoGiwvC961QVIu bHfYK4g38LaWlGjIgYDAMFGcAFZdlzFA8t/E9IAIYAryFbhlxjWG2xjE1XKmEP3t0mGL +0hVLbKDxxMg/Oeaf0mvZ0ohWi7rBaIHqKF0f8tRNHNgpot70KbIk0k4Arb87PpL5H4R KM//UcVm9k+F2HoZJ15zoaVK8iXq6ITWutY/FbUKsyhCR1G7fBn6AhEjsBSp10DjW8Vl 0qmg== X-Gm-Message-State: AOAM530y1il7ppgeMhvioCfpYsWM5MPXcOzGMTef5gZ7cBW8nUnTmTy5 TauGjXM0Qwo6CwRY7Kcetd1XQpYtZmT8KrBeAHh/UBciGjVHhFoUL2TYKokN78dmofJ2EGpTBtV S2LZEU/2/LU9Pw2qXMzqnBlVEDebCy0v74SK1Oh3KF43NMeJyIX2g73uLbOYsmO83ub5Hoc/Vsg == X-Received: by 2002:a05:620a:b4e:b0:6a5:9b54:2d91 with SMTP id x14-20020a05620a0b4e00b006a59b542d91mr39159318qkg.586.1655122394382; Mon, 13 Jun 2022 05:13:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyui2hxbFXA9npYe+zrYsrU2s6Z5wCdg74x7l4zvATa+lAo9ndXQjs83e8sotiGrU3ytiY4PA== X-Received: by 2002:a05:620a:b4e:b0:6a5:9b54:2d91 with SMTP id x14-20020a05620a0b4e00b006a59b542d91mr39159292qkg.586.1655122394034; Mon, 13 Jun 2022 05:13:14 -0700 (PDT) Received: from localhost (host109-154-20-145.range109-154.btcentralplus.com. [109.154.20.145]) by smtp.gmail.com with ESMTPSA id s137-20020a37a98f000000b006a6c230f5e0sm6381963qke.31.2022.06.13.05.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 05:13:13 -0700 (PDT) From: Andrew Burgess To: Sam James via Gdb-patches , gdb-patches@sourceware.org Cc: Sam James Subject: Re: [PATCH] gdb: don't use bashism in configure test In-Reply-To: <20220609033751.631855-1-sam@gentoo.org> References: <20220609033751.631855-1-sam@gentoo.org> Date: Mon, 13 Jun 2022 13:13:12 +0100 Message-ID: <87k09kep7r.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 12:13:28 -0000 Sam James via Gdb-patches writes: > Results in configure output like: > ``` > checking for X... no > /var/tmp/portage/sys-devel/gdb-12.1/work/gdb-12.1/gdb/configure: 18837: test: yes: unexpected operator > checking whether to use babeltrace... auto > ``` > > ... when /bin/sh is provided by a POSIX-compliant shell, like dash, > instead of bash. Thanks, I pushed this for you. Andrew > > Signed-off-by: Sam James > --- > gdb/configure | 2 +- > gdb/configure.ac | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/configure b/gdb/configure > index 1008cbef28b..1b821390801 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -18760,7 +18760,7 @@ else > fi > > > -if test "${enable_libbacktrace}" == "yes"; then > +if test "${enable_libbacktrace}" = "yes"; then > LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/" > LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a > > diff --git a/gdb/configure.ac b/gdb/configure.ac > index e3c19bc8859..bf03b875dfe 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -2113,7 +2113,7 @@ AC_ARG_ENABLE([libbacktrace], > esac], > enable_libbacktrace=yes) > > -if test "${enable_libbacktrace}" == "yes"; then > +if test "${enable_libbacktrace}" = "yes"; then > LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/" > LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a > AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used.]) > -- > 2.35.1