From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2D7AC385780C for ; Fri, 29 Apr 2022 10:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D7AC385780C Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-MN64lOoTOcan7YlDaPMyrQ-1; Fri, 29 Apr 2022 06:20:57 -0400 X-MC-Unique: MN64lOoTOcan7YlDaPMyrQ-1 Received: by mail-wm1-f71.google.com with SMTP id k5-20020a05600c0b4500b003941ca130f9so635156wmr.0 for ; Fri, 29 Apr 2022 03:20:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=kqJHe1We4FkrHPRJxAaZmmAghBZEHEXxCdouZCMiUiA=; b=rQT2YFD5f90yQ8XSsWorSyve0XKa0BBctgIjVBIxny7/NGyQFMtqAyDEW685cP8LAo jeB7FMHn8Orf0yQovOtOnIGy69aaXmVzfa9NZXlt70YPaFMau+nwfjMGC8UsAeZ1RZF8 gy6pHoYxM4fkL0Ngn/z+vCeqA3kk4Pge5PLG0T3F7QrIhGvCj8ISSRBzr+OLG4fA0N43 armmrovQrYSSXs5wTDL2hrKgq5IeEBqjyCFepvdpSUFrFBnLQt4EpdWETp/3i+oosku3 lpKM1aS8J4j+ajWCCMxrenoKx70QGCDV4sKwi9M9go27JE8v07hByA0CG6usQ/e/F6IL +vIg== X-Gm-Message-State: AOAM53253B7Rhn6EMO7GHrtbbzE1B6iGQMDVHE2JzYgo2Zcu26jHmuZW ihxds7o+sMBLJ+DfbZ6Agc2sWlN+lmUZ/IuNy+x81XcoYS0EqiUa7GFC1juEWZknGbD4X0qNl2z IsBvDLbghInnGTKPymTF+MQ== X-Received: by 2002:a05:6000:1048:b0:20a:ddcb:fc8 with SMTP id c8-20020a056000104800b0020addcb0fc8mr18680340wrx.674.1651227656633; Fri, 29 Apr 2022 03:20:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMBHqjXnkc4KbRJyCZiIx/Oq1Z2KLxlXVe29LtByps+glWqs+bbAAquVNEKlIAckip8VHA9w== X-Received: by 2002:a05:6000:1048:b0:20a:ddcb:fc8 with SMTP id c8-20020a056000104800b0020addcb0fc8mr18680324wrx.674.1651227656452; Fri, 29 Apr 2022 03:20:56 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id u22-20020adfa196000000b0020ad517ce4bsm2022450wru.52.2022.04.29.03.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 03:20:56 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH] Fix crash with "maintenance print arc" In-Reply-To: <87czh1mdoa.fsf@tromey.com> References: <20220427100753.364631-1-luis.machado@arm.com> <871qxiq00y.fsf@redhat.com> <87czh1mdoa.fsf@tromey.com> Date: Fri, 29 Apr 2022 11:20:55 +0100 Message-ID: <87k0b8nqbc.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 10:21:00 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > >>> While doing something else, I noticed GDB crashed with >>> "maintenance print arc". > > Andrew> I tried building current master, and "maintenance print arc" completes > Andrew> just fine (for me). Can you give more details on how to reproduce the > Andrew> crash? > > It crashes for me too. Instead of using completion, just invoke the > command directly. Thanks. When I looked at you proposed patch (which LGTM) that pointed me at why this wasn't working for me. Turns out I had a typo in the configure line for the build of GDB I was testing on '--enable-targts=all' so this arc specific command was not being compiled in, and instead 'maint print arc' was expanding to 'maint print architecture'. Thanks, Andrew