From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6BFC4385840F for ; Wed, 6 Apr 2022 12:18:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6BFC4385840F Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-wITyZemAMtqKC8BqAC8pZQ-1; Wed, 06 Apr 2022 08:18:13 -0400 X-MC-Unique: wITyZemAMtqKC8BqAC8pZQ-1 Received: by mail-wr1-f72.google.com with SMTP id t15-20020adfdc0f000000b001ef93643476so440641wri.2 for ; Wed, 06 Apr 2022 05:18:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=3nTNlSYlnO/g1TvDvf2ya9lmI1fPimcVkve+iH9+W60=; b=Mzdb43WylMTEgRJIytuMje3Y1aJlA8DV0avA/0qyqEmANwsFE7cGOfXyEAzvdI68xy NOs0PXND2PX373YeyJvVdgsBGP9k9NuTG+/FEwg0i+mrubqm3U4kZjb8wslyduQStAsB JYjrupcn1deLR1Ykzv0JNKgzSmvVePguoKj7ayXX85V+cm11JodMfxL5zYWXB+z9TPKG 2sXO1UXz3jNHgHmLzTY1SiZ3L+JkIWM39fRpcJ5cWKCOly/X1qkazSQr0b5HJloLNrCA 3PrNUANUtd4bCWuUVt1qkaYfQeupLQX8yOr2sXi2DX1yDBoswsoFVN5A65Ip8QzT0XQx O0Fg== X-Gm-Message-State: AOAM533L8sGXoKH27BXzdn2YS8eJBNEyNF6Ermzpha7gHKN7IaeLqTeq lRSkimv9HeBAGwruS8hc3ZuGkh4UHbXRrHVbcXG1iW6XA2PGwjugYGbf1X8zR3UnbSvCANH9dP/ C5F0qI4hF8S+nSugnUHhajA== X-Received: by 2002:a5d:6c66:0:b0:204:93b:5dee with SMTP id r6-20020a5d6c66000000b00204093b5deemr6330282wrz.332.1649247491862; Wed, 06 Apr 2022 05:18:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcY6KWy45hKHYINfs4KRW7GmQbffF0bGt6FKEW1gthvgFQXma+bzxdoWV60NrXLR+uJTOoDA== X-Received: by 2002:a5d:6c66:0:b0:204:93b:5dee with SMTP id r6-20020a5d6c66000000b00204093b5deemr6330269wrz.332.1649247491669; Wed, 06 Apr 2022 05:18:11 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037bb8df81a2sm5621051wmp.13.2022.04.06.05.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 05:18:10 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCHv3 1/6] gdb: move gdb_disassembly_flag into a new disasm-flags.h file In-Reply-To: <87bkxffvnz.fsf@tromey.com> References: <0ea56c5ecbca357d715457bd08c62d671b4ac4b7.1649110564.git.aburgess@redhat.com> <87bkxffvnz.fsf@tromey.com> Date: Wed, 06 Apr 2022 13:18:09 +0100 Message-ID: <87k0c276da.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 12:18:15 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> In this commit I move gdb_disassembly_flag into its own file. This is > Andrew> then included in target.h and disasm.h, after which, the number of > Andrew> files that need to include disasm.h is much reduced. > > Andrew> Now, after changing disasm.h, GDB rebuilds much quicker. > > Looks good to me. Thanks. I've gone ahead and pushed this patch on its own for now. Andrew