From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 96CE33858010 for ; Sun, 3 Apr 2022 14:43:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96CE33858010 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-414-MXcNbA6aNF63PlU4BQGUAw-1; Sun, 03 Apr 2022 10:43:24 -0400 X-MC-Unique: MXcNbA6aNF63PlU4BQGUAw-1 Received: by mail-wm1-f71.google.com with SMTP id k16-20020a7bc310000000b0038e6cf00439so1528177wmj.0 for ; Sun, 03 Apr 2022 07:43:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=QMWQrBd6ij93vK7Efb13mhkHk37OvgUCQpOvZfgQBOU=; b=nDMRukUYv0jBLiaXDgsIKi09g9uQsqibXOYSvqBtTkeNN9Ady6BCGOkBi/xMabtnxI JJnHcrz2Az+M2Wa0JxJtLZb3VTzQrVVS3OWJnOopyo5CNM4WPyOT8pOo8QglThxH3ngD DWvJdZCJTCHafQPDzeCYekRIcUg6OtFu5Tdi9TlAYqH52CLjsVEuBZCUXV7nC7Os3AjI 7VTumTqsT6PSNYVBNzwEEK7pbcUOWZmKxHzUw1NftAChS0Q0fL6l7BieY38KNt9zprXl clkzTuM3Gq3ro5KCR/xqZ5y0cd72Au7aeSvPxbN1PtecjEzgcVIbU2keU0RBrQgaFoJo IyKw== X-Gm-Message-State: AOAM533yDZG1HEf16rhfSQvH2FqYDmhaegPD5fGJaASJtnKHnYslbgnH rZGSpLDHy6817WTKlbZ8XMLB1n4TQgdqQQSXPuJC+2yhAQubAh/B+XeoCHmY2J1OBefzCXbhkPd TnBekB4666XzPz1ZoVrBGYHXDqe+wvuHuoBDeWw/M6gF9s1qg9xeZmUvMCP1UXv/O8h8FzKNxyA == X-Received: by 2002:adf:e2cb:0:b0:203:7564:1076 with SMTP id d11-20020adfe2cb000000b0020375641076mr14244083wrj.199.1648997003531; Sun, 03 Apr 2022 07:43:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBgvw8VNMbzM7wFr0e0fdcabPfJUmFX+jxbfAvPup0YVdCw1yuHlKaAieLtJrPpxd+90/lkw== X-Received: by 2002:adf:e2cb:0:b0:203:7564:1076 with SMTP id d11-20020adfe2cb000000b0020375641076mr14244078wrj.199.1648997003298; Sun, 03 Apr 2022 07:43:23 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id e9-20020a5d6d09000000b00203ecdca5b7sm7540895wrq.33.2022.04.03.07.43.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 07:43:22 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv3 00/15] TUI changes, new winwidth command and resizing changes In-Reply-To: <87bkxnajlq.fsf@redhat.com> References: <87y213ry5l.fsf@redhat.com> <87bkxnajlq.fsf@redhat.com> Date: Sun, 03 Apr 2022 15:43:21 +0100 Message-ID: <87k0c68bxy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2022 14:43:29 -0000 Andrew Burgess writes: > I'm planning to push this series soon(ish) unless someone complains. I've now pushed this series. Thanks, Andrew > > The only series comments on v2 were for patch #5, which I believe are > now addressed. > > As always, if there's any feedback post-commit, I'm happy to address > issues as they are raised. > > Thanks, > Andrew > > > Andrew Burgess writes: > >> Ping! >> >> Thanks, >> Andrew >> >> >> Andrew Burgess writes: >> >>> Since v2: >>> >>> - Rebased onto current upstream/master, >>> >>> - Patch #5 - Rewritten to not use templates! >>> >>> - Patch #6 - Added a bug in bugzilla, and referenced this from the >>> commit message, >>> >>> - Patch #7 - Renamed the existing methods rather than adding 2 new >>> methods, >>> >>> - Patch #10 - Updated the comment Tom identified as being out of >>> date, >>> >>> - Patch #15 - Have updated a comment that I spotted was out of date. >>> >>> Thanks, >>> Andrew >>> >>> >>> --- >>> >>> Andrew Burgess (15): >>> gdb: move some commands into the tui namespace >>> gdb/tui: rename tui_layout_base::adjust_size to ::set_height >>> gdb/tui: rename tui_layout_split:set_weights_from_heights >>> gdb/testing/tui: add new functionality to tuiterm.exp >>> gdb/tui: add new 'tui window width' command and 'winwidth' alias >>> gdb/tui: add a tui debugging flag >>> gdb/tui: add left_boxed_p and right_boxed_p member functions >>> gdb/tui/testsuite: refactor new-layout.exp test >>> gdb/tui: avoid fp exception when applying layouts >>> gdb/tui: fairer distribution of excess space during apply >>> gdb/tui: allow cmd window to change size in tui_layout_split::apply >>> gdb/tui: support placing the cmd window into a horizontal layout >>> gdb/testsuite: some additional tests in gdb.tui/scroll.exp >>> gdb/tui: relax restrictions on window max height and width >>> gdb/tui: fair split of delta after a resize >>> >>> gdb/NEWS | 25 ++ >>> gdb/doc/gdb.texinfo | 51 +++- >>> gdb/testsuite/gdb.tui/basic.exp | 4 +- >>> gdb/testsuite/gdb.tui/empty.exp | 14 +- >>> gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++-- >>> gdb/testsuite/gdb.tui/regs.exp | 4 +- >>> gdb/testsuite/gdb.tui/scroll.exp | 4 + >>> gdb/testsuite/gdb.tui/winheight.exp | 77 +++++ >>> gdb/testsuite/gdb.tui/winwidth.exp | 63 +++++ >>> gdb/testsuite/lib/tuiterm.exp | 82 +++++- >>> gdb/tui/tui-command.c | 6 - >>> gdb/tui/tui-command.h | 2 - >>> gdb/tui/tui-layout.c | 406 ++++++++++++++++++++++----- >>> gdb/tui/tui-layout.h | 135 +++++++-- >>> gdb/tui/tui-win.c | 118 ++++++-- >>> gdb/tui/tui.c | 26 ++ >>> gdb/tui/tui.h | 14 + >>> 17 files changed, 971 insertions(+), 160 deletions(-) >>> create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp >>> >>> -- >>> 2.25.4