From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] gdb: remove internalvar_funcs::destroy
Date: Fri, 04 Mar 2022 09:15:57 -0700 [thread overview]
Message-ID: <87k0d9u20y.fsf@tromey.com> (raw)
In-Reply-To: <20220201140717.3046952-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 1 Feb 2022 09:07:14 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> No kind of internal var uses it remove it. This makes the transition to
Simon> using a variant easier, since we don't need to think about where this
Simon> should be called (in a destructor or not), if it can throw, etc.
It seems to me that this one could go in right away.
Tom
next prev parent reply other threads:[~2022-03-04 16:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 14:07 [PATCH 0/4] Add variant type Simon Marchi
2022-02-01 14:07 ` [PATCH 1/4] gdb: remove internalvar_funcs::destroy Simon Marchi
2022-03-04 16:15 ` Tom Tromey [this message]
2022-03-06 16:33 ` Simon Marchi
2022-02-01 14:07 ` [PATCH 2/4] gdb: constify parameter of value_copy Simon Marchi
2022-03-04 16:16 ` Tom Tromey
2022-03-06 16:33 ` Simon Marchi
2022-02-01 14:07 ` [PATCH 3/4] gdbsupport: add variant-lite header Simon Marchi
2022-02-01 14:07 ` [PATCH 4/4] gdb: make internalvar use a variant Simon Marchi
2022-03-04 16:23 ` Tom Tromey
2022-03-07 12:12 ` Pedro Alves
2022-03-16 2:06 ` Simon Marchi
2022-03-16 13:26 ` Pedro Alves
2022-03-16 13:28 ` Simon Marchi
2022-02-03 0:02 ` [PATCH 0/4] Add variant type Andrew Burgess
2022-02-03 1:32 ` Simon Marchi
2022-02-04 12:44 ` Andrew Burgess
2022-02-04 13:19 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0d9u20y.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).