From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id CD7E43858D1E for ; Thu, 10 Feb 2022 19:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD7E43858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 15F3510047287 for ; Thu, 10 Feb 2022 19:47:04 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id IFPCnpwFInAlUIFPDnjD9n; Thu, 10 Feb 2022 19:47:03 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=62056bb7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oGFeUVbbRNcA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=lAPpIcWbxx70n369KTMA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5b68Y6mLdGamxCLb4Tw2P9eMWIcEj62QOG22vvVAva4=; b=EKH8OmLIV31+yPuZ+yk40zcPt7 MZdT/lUpJEl6PgM/1LnAm18gsM29qr/Fa6TH4aYdm1nWrm699ucmspZGTy1zwbOc2O7gZK3x5EWBv ZaQOp1n9YLnouSrLgeHdyVzyC; Received: from 75-166-128-165.hlrn.qwest.net ([75.166.128.165]:55986 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIFPC-002qJ7-LV; Thu, 10 Feb 2022 12:47:02 -0700 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Subject: Re: [PATCH 2/2] gdb: Resolve dynamic target types of pointers. References: <20220118132626.3786176-1-nils-christian.kempke@intel.com> <20220118132626.3786176-3-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Thu, 10 Feb 2022 12:47:01 -0700 In-Reply-To: <20220118132626.3786176-3-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Tue, 18 Jan 2022 14:26:26 +0100") Message-ID: <87k0e2tsga.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.128.165 X-Source-L: No X-Exim-ID: 1nIFPC-002qJ7-LV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-128-165.hlrn.qwest.net (murgatroyd) [75.166.128.165]:55986 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 19:47:06 -0000 >>>>> Nils-Christian Kempke via Gdb-patches writes: Hi. Thanks for the patch. > + if (type->code () == TYPE_CODE_PTR && is_dynamic_type (type)) > + { > + CORE_ADDR addr; > + if (nullptr != TYPE_DATA_LOCATION (TYPE_TARGET_TYPE (type))) > + addr = value_address (val); > + else > + addr = value_as_address (val); This seems weird to me. When does value_as_address fail? It seems to me that a value whose type is TYPE_CODE_PTR should be more easily convertible to a CORE_ADDR without examining TYPE_DATA_LOCATION. The same thing applies in a couple more spots in the patch. I'm curious why the code added here is not also needed in f-valprint.c. > --- a/gdb/testsuite/gdb.cp/vla-cxx.exp > +++ b/gdb/testsuite/gdb.cp/vla-cxx.exp > @@ -23,6 +23,36 @@ if ![runto_main] { > return -1 > } > +gdb_breakpoint [gdb_get_line_number "Before pointer assignment"] > +gdb_continue_to_breakpoint "Before pointer assignment" > + > +set test_name "ptype ptr, Before pointer assignment" > +gdb_test_multiple "ptype ptr" $test_name { > + # gfortran > + -re "= int \\(\\*\\)\\\[variable length\\\]\r\n$gdb_prompt $" { > + pass $test_name > + } > + # ifort/ifx This references fortran compilers but is a c++ test. > +gdb_test "ptype ptr" "int \\(\\*\\)\\\[3\\\]" > +gdb_test "print ptr" "\\(int \\(\\*\\)\\\[3\\\]\\) $hex" > +gdb_test "print *ptr" " = \\{5, 7, 9\\}" Do these pass with all compilers or do they also need to be conditional? thanks, Tom