From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.200]) by sourceware.org (Postfix) with ESMTPS id 7A9A83858D39 for ; Wed, 20 Oct 2021 21:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A9A83858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id AB1B83FCA4 for ; Wed, 20 Oct 2021 16:42:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dJMOm1fuEOnCIdJMOmfh9q; Wed, 20 Oct 2021 16:42:56 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Uhx0nplj3J7O/DcfsizO/QmPBZGtxzZfKyPOwrLuyyk=; b=K7DtDJaZuL8yZN64a1tmsqh+w+ LYtdjsCfbieHNC+FI6rUu56krBJbVD7rIYM3ZUWOj6sB+J74YLB56PzquVn77QRqLN20ba1oRCTwH piJB1eIC9LYFdLZyFnbGE5FuR; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54036 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mdJMO-0004Vl-80; Wed, 20 Oct 2021 15:42:56 -0600 From: Tom Tromey To: Keith Seitz via Gdb-patches Cc: Tom Tromey , Keith Seitz Subject: Re: [PATCH] Resolve dynamic types before computing pointer size References: <20210916164248.2065236-1-keiths@redhat.com> <874k9dx9xf.fsf@tromey.com> X-Attribution: Tom Date: Wed, 20 Oct 2021 15:42:55 -0600 In-Reply-To: (Keith Seitz via Gdb-patches's message of "Wed, 20 Oct 2021 12:29:22 -0700") Message-ID: <87k0i7tlsw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mdJMO-0004Vl-80 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54036 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2021 21:43:08 -0000 >>>>> "Keith" == Keith Seitz via Gdb-patches writes: Keith> Unfortunately, my patch to find_size_for_pointer_math interferes with your recently committed Keith> patch ["Fix bug in dynamic type resolution"], which you "snuck" [:-)] in before I could finish Keith> rebasing and retesting my patch. Sorry about that. Keith> With my patch applied: Keith> +FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first element of another_array Keith> +FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print second element of another_array Keith> In both cases, we see "Cannot access memory at address 0x4". Does the test pass without your patch? I wonder if there's some other problem -- the Ada tests tend to be fairly compiler-dependent. Tom