Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls

[Sergio Durigan Junior <sergiodj@sergiodj.net>]

On Thursday, October 07 2021, Ulrich Weigand via Gdb-patches wrote:

> "Carl Love" <cel@us.ibm.com> wrote on 05.10.2021 22:59:06:
>
>> +  else if (syscall == 286)
>> +    result = gdb_sys_openat;
>
> This looks OK, but ...
>
>> +  else if (syscall == 291)
>> +    result = gdb_sys_fstatat64;
>
> syscall 291 is actually different between 32-bit
> and 64-bit: on 32-bit it is fstatat64, but on
> 64-bit it is newfstatat.
>
> Given that this routine seems to be used for
> both flavors, it should be correct for both.
>
> (Also, there seem to be many more syscalls that
> are not handled even though they could be.  But
> that can be left for another time I guess ...)

As a side note, and something that has bothered me for many years now:
this entire file relies on hardcoded syscall values, while GDB maintains
XML files for syscalls in several different architectures due to the
"catch syscall" command.  Ideally the reverse/record feature should be
rewritten to use those XML files instead.

Ref.: https://sourceware.org/bugzilla/show_bug.cgi?id=17402

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/