From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.69.18]) by sourceware.org (Postfix) with ESMTPS id 3B69F39730F6 for ; Wed, 2 Jun 2021 18:39:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B69F39730F6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 0E912401043FD for ; Wed, 2 Jun 2021 13:26:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oVm4lK3jxR1jIoVm4lwdAq; Wed, 02 Jun 2021 13:39:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BvPvtoN6zhx4edylBiy9TvFckWPrNBv83hhadHkqQ80=; b=Xqv5R9ZgPDLVC8/Y79EGtePSH2 /F4WLjgfbVhE4mxIWZOjLCz0FBYzTCrLsRlCIslA9JlYIciwSyrnuaC0/n1VLuexjvnsZ3/MjjVel eazOFIlbPv25HYYLMiINffvwV; Received: from 75-166-132-3.hlrn.qwest.net ([75.166.132.3]:47824 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1loVm3-003y8M-VA; Wed, 02 Jun 2021 12:39:28 -0600 From: Tom Tromey To: Hannes Domani via Gdb-patches Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant References: <20210526170536.657-1-ssbssa.ref@yahoo.de> <20210526170536.657-1-ssbssa@yahoo.de> X-Attribution: Tom Date: Wed, 02 Jun 2021 12:39:27 -0600 In-Reply-To: <20210526170536.657-1-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Wed, 26 May 2021 19:05:36 +0200") Message-ID: <87k0ncp0v4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.132.3 X-Source-L: No X-Exim-ID: 1loVm3-003y8M-VA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-132-3.hlrn.qwest.net (murgatroyd) [75.166.132.3]:47824 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 18:39:47 -0000 >>>>> "Hannes" == Hannes Domani via Gdb-patches writes: Hannes> It was removed (probably by mistake) in Hannes> 51e78fc5fa21870d415c52f90b93e3c6ad57be46. Yes, sorry about that. Hannes> gdb/ChangeLog: Hannes> 2021-05-26 Hannes Domani Hannes> * python/py-symbol.c (gdbpy_initialize_symbols): Restore Hannes> gdb.SYMBOL_LABEL_DOMAIN constant. Hannes> gdb/testsuite/ChangeLog: Hannes> 2021-05-26 Hannes Domani Hannes> * gdb.python/py-symbol.exp: Test symbol constants. This is ok. Thank you. Hannes> +# Test gdb.Symbol domain categories Hannes> +gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \ Hannes> + "0" "test gdb.SYMBOL_UNDEF_DOMAIN" Hannes> +gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \ Hannes> + "1" "test gdb.SYMBOL_VAR_DOMAIN" While we don't want people to rely on the values of these constants, it seems harmless in the test suite. If someone changes one, they can just update the test. Tom