From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.206]) by sourceware.org (Postfix) with ESMTPS id E42223853806 for ; Fri, 7 May 2021 16:47:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E42223853806 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 57F581A743 for ; Fri, 7 May 2021 11:47:55 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f3drl91uTDedff3drlR681; Fri, 07 May 2021 11:47:55 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ecxq/9jDJkFzKziGvc7ojm77WgecpED5W6C3WmFE+EU=; b=k/XFmbHsz6J8B8q6/RejmW2diY LIdpL0TgQLR21XX+d24cOiMQxLLPdxfHZxb5zC73O0WKKcuvgTqUZg7aXZBbqa9GMkaJaWFNe91iK MOHJ5XKQpwG+Jr1CLv+tZLa5h; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:39210 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lf3dq-001mgq-Tj; Fri, 07 May 2021 10:47:54 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi via Gdb-patches , Simon Marchi Subject: Re: [PATCH 1/5] gdb: make target_close check that the target isn't pushed in all inferiors References: <20210506142806.30363-1-simon.marchi@polymtl.ca> <87sg2yobk3.fsf@tromey.com> <486fc882-7b95-82f2-3b69-d6238c8b5a6a@efficios.com> X-Attribution: Tom Date: Fri, 07 May 2021 10:47:54 -0600 In-Reply-To: <486fc882-7b95-82f2-3b69-d6238c8b5a6a@efficios.com> (Simon Marchi's message of "Fri, 7 May 2021 11:42:25 -0400") Message-ID: <87k0oao5hh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1lf3dq-001mgq-Tj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:39210 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 16:47:57 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> I see what you mean. Given that: Simon> 1. disabling gdb_assert is not possible today (and not for the Simon> foreseeable future) Simon> 2. this is really not a hot path Simon> I would value code readability and debugging convenience over a Simon> premature optimization like this. We discussed this on irc, and FAOD I agree. Thanks. Tom