From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.59]) by sourceware.org (Postfix) with ESMTPS id 554EA3890402 for ; Thu, 11 Mar 2021 21:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 554EA3890402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 7B2D22A74 for ; Thu, 11 Mar 2021 15:33:25 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KSvtlbMcuA1KVKSvtluaah; Thu, 11 Mar 2021 15:33:25 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yrnIVF4UHkCkCW/prhiiu52sYwKVkNxVKC4beo6vXho=; b=tzOLJPxQmKbqYV7wcv/V5fNCSP JRq3+YGdOb4yYtn4A9WwubKAdqBxGo3artr6wTadNo5RO+kfP80gYr+ojf20FMLNyMWQpeUavw8YQ cvzplz0Qnuy3PNamHaQAAuGgj; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:35554 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKSvt-000YQt-5u; Thu, 11 Mar 2021 14:33:25 -0700 From: Tom Tromey To: Hannes Domani via Gdb-patches Subject: Re: [PATCH 05/22] Implement locals TUI window References: <20210306173417.21528-1-ssbssa@yahoo.de> <20210306173417.21528-6-ssbssa@yahoo.de> X-Attribution: Tom Date: Thu, 11 Mar 2021 14:33:24 -0700 In-Reply-To: <20210306173417.21528-6-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Sat, 6 Mar 2021 18:34:00 +0100") Message-ID: <87k0qd5qaj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lKSvt-000YQt-5u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:35554 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 21:33:31 -0000 >>>>> "Hannes" == Hannes Domani via Gdb-patches writes: Hannes> PR tui/17849 I didn't read this in detail, or try it, but I'm definitely supportive of the concept. I had some trouble with the structure of the code. I guess I'd prefer some of the longer functions be split up. I'm fine with new windows being written in Python. Hannes> +col_esc_seq_re = re.compile('(\033\[[0-9;]*m)') Ouch but I see the need for this kind of thing. Hannes> +gdb.events.before_prompt.connect(var_change_handler) I wonder if this should be a bit more fine-grained; but also whether it can be. In many situations there's no need to do anything. Like "print blah" -> nothing changed. OTOH I'm not sure if Python can detect that a variable's value changed, say by the user setting it. So maybe constantly refreshing is the best we can currently do? Hannes> +gdb.execute("alias ll = layout locals") I saw a note, I think from Andrew, elsewhere in the thread about short names. I'm also more in favor of long names, and let users write the short ones as aliases if they want. I'm +1 on new useful layouts though. I know some other short names have gone in, but I wish I had said something about those at the time. Tom