From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.164]) by sourceware.org (Postfix) with ESMTPS id 4698138708C5 for ; Thu, 11 Mar 2021 17:32:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4698138708C5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id ACF974D5D for ; Thu, 11 Mar 2021 11:32:30 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KPAklMTLE5rKQKPAklbuKj; Thu, 11 Mar 2021 11:32:30 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MGQBTI0iYQJbQLcBOl0HfxDPDbJuYe4kDsy+j3xPCVM=; b=wmSCYSsmnw+TM2JOTqWFY91bWX 0NF8utQdAAGaah0NU8cFQrfSI4RHJOLXKAps6AKS1/nNIVupUzlG/3AvQ/+j/ykTmRMSC1Brreq6c gkEzbS8pvo7tg89GTr6dr1e0r; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:34396 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKPAk-001VYC-Bc; Thu, 11 Mar 2021 10:32:30 -0700 From: Tom Tromey To: Hannes Domani via Gdb-patches Subject: Re: [PATCH 01/22] Initial TUI mouse support References: <20210306173417.21528-1-ssbssa@yahoo.de> <20210306173417.21528-2-ssbssa@yahoo.de> X-Attribution: Tom Date: Thu, 11 Mar 2021 10:32:29 -0700 In-Reply-To: <20210306173417.21528-2-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Sat, 6 Mar 2021 18:33:56 +0100") Message-ID: <87k0qd7g0i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lKPAk-001VYC-Bc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:34396 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 17:32:33 -0000 >>>>> "Hannes" == Hannes Domani via Gdb-patches writes: Hannes> Implements an overridable tui_win_info::click method whose arguments Hannes> are the mouse coordinates inside the specific window, and the mouse Hannes> button clicked. Thank you. This is a very welcome development. I won't comment on tests or comments in the code. Hannes> +#ifdef BUTTON5_PRESSED Hannes> + else if (mev.bstate & BUTTON4_PRESSED) Hannes> + wi->backward_scroll (3); Hannes> + else if (mev.bstate & BUTTON5_PRESSED) Hannes> + wi->forward_scroll (3); Hannes> +#endif One question I have here is that, right now, the mouse wheel already works to scroll for me. I assume this won't change. But I wonder why new code is needed. Maybe it's the case that if you enable mouse events, curses turns off automatic translation of scroll wheel to scrolling? Tom