From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.4.169]) by sourceware.org (Postfix) with ESMTPS id 9FB36383F849 for ; Mon, 15 Jun 2020 15:02:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9FB36383F849 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id AB9D3400FDD7E for ; Mon, 15 Jun 2020 08:42:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kqcojHJ33XGIkkqcpjoZpg; Mon, 15 Jun 2020 10:02:15 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+tnwmN4BaqWtvaCbgJAtjksIpFGh3/Q/v414RTgQXgg=; b=bWxQ+QB29dtbl1U5e3bDPFz8aR s5GtLEPFglPtWSTIyUe1O/7LCIkTnoywhcZjI447nscYX5u02ElW+dcl/yrdGtCV8ZzeFOC5CnsSt ce/NgaaHwM6pcAUKG7Ny8QDif; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:58846 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jkqco-000MlG-M6; Mon, 15 Jun 2020 09:02:14 -0600 From: Tom Tromey To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] guile: Add support for Guile 3.0. References: <20200612132710.14364-1-ludo@gnu.org> <20200612132710.14364-3-ludo@gnu.org> X-Attribution: Tom Date: Mon, 15 Jun 2020 09:02:13 -0600 In-Reply-To: <20200612132710.14364-3-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Fri, 12 Jun 2020 15:27:10 +0200") Message-ID: <87k108l6dm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jkqco-000MlG-M6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:58846 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 15:02:18 -0000 >>>>> "Ludovic" =3D=3D Ludovic Court=C3=A8s writes: Ludovic> * testsuite/gdb.guile/source2.scm: Add #f first argument to Ludovic> 'format'. Ludovic> * testsuite/gdb.guile/types-module.exp: Remove "ERROR:" from Ludovic> regexps since Guile 3.0 no longer prints that. testsuite/ (unfortunately IMO) has its own ChangeLog. Ludovic> /* If scm_is_unsigned_integer can't work with this type, ju= st punt. */ Ludovic> - if (TYPE_LENGTH (type) > sizeof (scm_t_uintmax)) Ludovic> + if (TYPE_LENGTH (type) > sizeof (uintmax_t)) I suppose these can't differ in Guile 2.0 or 2.2? Anyway, this patch seems fine to me. Tom