From: Tom Tromey <tom@tromey.com>
To: nitachra <Nitika.Achra@amd.com>
Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com
Subject: Re: [PATCH] Fix for the complaint observed when symbol reading due to unsupported .debug_names form.
Date: Thu, 07 May 2020 07:26:04 -0600 [thread overview]
Message-ID: <87k11nzxjn.fsf@tromey.com> (raw)
In-Reply-To: <20200504061319.3699-1-Nitika.Achra@amd.com> (nitachra's message of "Mon, 4 May 2020 11:43:19 +0530")
>>>>> ">" == nitachra <Nitika.Achra@amd.com> writes:
>> Following complaint is observed with the executable compiled with -gdwarf-5
>> and -gpubnames flags- "During symbol reading: Unsupported .debug_names form
>> DW_FORM_ref4". This is the form corresponding to DW_IDX_die_offset attribute.
>> This patch fixes this complaint. Tested with clang 10.0.0. Test case used-
>> int main()
>> {
>> int sum,a,b;
>> sum = a + b;
>> return sum;
>> }
Does it fail some existing test in the gdb testsuite?
Normally what we like to see is either that a patch fixes some existing
failure (perhaps when the test suite is run in a certain way); or a new
test that fails before the patch and passes afterward.
>> + case DW_IDX_die_offset:
>> + /* In a per_cu index, index entries without CU attribute implicitly refer to the
This line looks too long to me.
Tom
next prev parent reply other threads:[~2020-05-07 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 6:13 nitachra
2020-05-07 13:26 ` Tom Tromey [this message]
2020-05-08 14:36 ` Tom de Vries
2020-05-08 15:16 ` Tom de Vries
2020-05-09 8:05 ` Tom de Vries
2020-05-11 17:50 nitachra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k11nzxjn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=JiniSusan.George@amd.com \
--cc=Nitika.Achra@amd.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).