From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v2] Guard against 'current_directory == NULL' on gdb_abspath (PR gdb/23613)
Date: Fri, 13 Dec 2019 22:23:00 -0000 [thread overview]
Message-ID: <87k16zvp9t.fsf@tromey.com> (raw)
In-Reply-To: <20191121193729.26315-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Thu, 21 Nov 2019 14:37:29 -0500")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> gdb/ChangeLog:
Sergio> 2019-11-21 Sergio Durigan Junior <sergiodj@redhat.com>
Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1728147
Sergio> PR gdb/23613
Sergio> * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
Sergio> * corelow.c: Include 'gdbsupport/pathstuff.h'.
Sergio> (core_target_open): Use 'gdb_abspath'.
Sergio> * gdbsupport/pathstuff.c (gdb_abspath): Guard against
Sergio> 'current_directory == NULL' case.
Sergio> * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
Sergio> explain what happens when 'current_directory' is NULL.
Sergio> * go32-nat.c (go32_nat_target::wait): Check if
Sergio> 'current_directory' is NULL before call to 'chdir'.
Sergio> * source.c (add_path): Use 'gdb_abspath'.
Sergio> * top.c: Include 'gdbsupport/pathstuff.h'.
Sergio> (init_history): Use 'gdb_abspath'.
Sergio> (set_history_filename): Likewise.
Sergio> * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
Sergio> (tfile_target_open): Use 'gdb_abspath'.
Thanks. This is ok.
Tom
next prev parent reply other threads:[~2019-12-13 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 23:46 [PATCH] " Sergio Durigan Junior
2019-07-11 16:05 ` Tom Tromey
2019-07-12 1:21 ` Sergio Durigan Junior
2019-11-21 19:37 ` [PATCH v2] " Sergio Durigan Junior
2019-12-10 16:21 ` Sergio Durigan Junior
2019-12-13 22:23 ` Tom Tromey [this message]
2019-12-14 4:50 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k16zvp9t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).