public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] Add an objfile getter to gdb.Type
Date: Tue, 28 May 2019 22:07:00 -0000	[thread overview]
Message-ID: <87k1ea5j2i.fsf@tromey.com> (raw)
In-Reply-To: <20190523213729.27928-1-cbiesinger@google.com> (Christian	Biesinger via gdb-patches's message of "Thu, 23 May 2019 16:37:29	-0500")

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> This allows users of the Python API to find the objfile where a type
Christian> was defined.

Could you say what your motivation is for adding this?

The reason I ask is that I still harbor some hopes that we can complete
the "objfile splitting" project, and if so, then it wouldn't be possible
to associate a type with a single objfile.

I suppose maybe we could make the Python wrappers per-objfile.  So, this
patch maybe wouldn't necessarily limit this.

The patch itself looks fine to me.

Tom

  reply	other threads:[~2019-05-28 22:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 18:40 Christian Biesinger via gdb-patches
2019-05-23 19:01 ` Eli Zaretskii
2019-05-23 19:34 ` Simon Marchi
2019-05-23 20:36   ` Christian Biesinger via gdb-patches
2019-05-23 20:32 ` Christian Biesinger via gdb-patches
2019-05-23 21:06   ` Simon Marchi
2019-05-23 21:25     ` Christian Biesinger via gdb-patches
2019-05-23 21:37   ` Christian Biesinger via gdb-patches
2019-05-28 22:07     ` Tom Tromey [this message]
2019-05-30 17:01       ` Christian Biesinger via gdb-patches
2019-06-03 19:50         ` Tom Tromey
2019-06-03 20:28           ` Christian Biesinger via gdb-patches
2019-06-04 15:47             ` Tom Tromey
2019-06-04 21:48               ` Pedro Alves
2019-06-04 22:07                 ` Christian Biesinger via gdb-patches
2019-06-05  1:51                   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1ea5j2i.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).