public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb/testsuite: Don't allow paths to appear in test name
@ 2019-01-11 23:30 Andrew Burgess
  2019-01-12  3:37 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Burgess @ 2019-01-11 23:30 UTC (permalink / raw)
  To: gdb-patches; +Cc: Andrew Burgess

Having paths in the test names makes it harder to compare results
between two runs in different directories.  Give the test a name so
that the path doesn't appear.

gdb/ChangeLog:

	* gdb.base/style.exp: Don't include path in testname.
---
 gdb/testsuite/ChangeLog          | 4 ++++
 gdb/testsuite/gdb.base/style.exp | 1 +
 2 files changed, 5 insertions(+)

diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp
index 268f8018cd9..78d04b02903 100644
--- a/gdb/testsuite/gdb.base/style.exp
+++ b/gdb/testsuite/gdb.base/style.exp
@@ -54,4 +54,5 @@ save_vars { env(TERM) } {
     set quoted [string_to_regexp $binfile]
     gdb_test "file $binfile" \
 	"Reading symbols from \033\\\[32m${quoted}\033\\\[m..." \
+	"filename is styled when loading symbol file"
 }
-- 
2.14.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb/testsuite: Don't allow paths to appear in test name
  2019-01-11 23:30 [PATCH] gdb/testsuite: Don't allow paths to appear in test name Andrew Burgess
@ 2019-01-12  3:37 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2019-01-12  3:37 UTC (permalink / raw)
  To: Andrew Burgess; +Cc: gdb-patches

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Having paths in the test names makes it harder to compare results
Andrew> between two runs in different directories.  Give the test a name so
Andrew> that the path doesn't appear.

Andrew> gdb/ChangeLog:

Andrew> 	* gdb.base/style.exp: Don't include path in testname.

Thanks, this is ok.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-12  3:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 23:30 [PATCH] gdb/testsuite: Don't allow paths to appear in test name Andrew Burgess
2019-01-12  3:37 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).