From: Tom Tromey <tom@tromey.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/5] Merge common proc_service headers
Date: Fri, 05 Oct 2018 14:23:00 -0000 [thread overview]
Message-ID: <87k1mwh3q6.fsf@tromey.com> (raw)
In-Reply-To: <20181001082153.GA2652@blade.nx> (Gary Benson's message of "Mon, 1 Oct 2018 09:21:54 +0100")
>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
Gary> Tom Tromey wrote:
Gary> This series merges the majority of both into a new common file.
>>
Tom> What's left over?
>>
>> Answering my own question, it was the definition of struct
>> ps_prochandle, which differs between gdb and gdbserver; and is one
>> of the things that users of libthread_db are expected to define.
>>
>> If there were somewhere else to put these we could remove the
>> wrapper headers, which might be nice.
Gary> linux-nat.h for GDB, linux-low.h for gdbserver?
Not sure. I think nominally the thread-db stuff is separate from this layer?
Anyway it can be a topic for another day, I don't think it should hold
up this series.
Tom
prev parent reply other threads:[~2018-10-05 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 14:50 Gary Benson
2018-09-28 14:50 ` [PATCH 3/5] Update GDB gdb_proc_service.h workaround to match gdbserver Gary Benson
2018-09-28 19:36 ` Tom Tromey
2018-09-28 14:50 ` [PATCH 2/5] Add workaround from gdbserver's gdb_proc_service.h to GDB Gary Benson
2018-09-28 19:34 ` Tom Tromey
2018-09-28 14:50 ` [PATCH 1/5] gdb_proc_service.h comment and whitespace synchronization Gary Benson
2018-09-28 19:28 ` Tom Tromey
2018-09-28 14:58 ` [PATCH 4/5] Move duplicated code to common/gdb_proc_service.h Gary Benson
2018-09-28 19:40 ` Tom Tromey
2018-09-28 14:59 ` [PATCH 5/5][OPTIONAL] Remove ancient workaround Gary Benson
2018-09-28 19:44 ` Tom Tromey
2018-09-28 19:33 ` [PATCH 0/5] Merge common proc_service headers Tom Tromey
2018-09-28 19:46 ` Tom Tromey
2018-10-01 8:27 ` Gary Benson
2018-10-05 14:23 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1mwh3q6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).