From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Support ptype/o in Rust
Date: Tue, 26 Jun 2018 20:55:00 -0000 [thread overview]
Message-ID: <87k1qls1x4.fsf@tromey.com> (raw)
In-Reply-To: <264bed6a37ca5474bfb51565789905bf@polymtl.ca> (Simon Marchi's message of "Tue, 26 Jun 2018 15:08:27 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>> + // When printing offsets, we rearrange the fields into storage
>> + // order. This lets us show holes more clearly. We work using
>> + // field indices here because it simplifies calls to
>> + // print_offset_data::update below.
Simon> Use /**/ comments.
Oops, too much project switching. Thanks for pointing this out.
I've fixed this.
Tom
next prev parent reply other threads:[~2018-06-26 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 20:22 [RFA 0/2] " Tom Tromey
2018-06-23 20:22 ` [RFA 2/2] " Tom Tromey
2018-06-26 19:08 ` Simon Marchi
2018-06-26 20:55 ` Tom Tromey [this message]
2018-06-23 20:22 ` [RFA 1/2] Move ptype/o printing code to typeprint.c Tom Tromey
2018-06-23 23:51 ` Sergio Durigan Junior
2018-06-26 20:54 ` Tom Tromey
2018-06-23 23:44 ` [RFA 0/2] Support ptype/o in Rust Sergio Durigan Junior
2018-06-27 2:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1qls1x4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).