From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44191 invoked by alias); 17 Apr 2018 19:37:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44179 invoked by uid 89); 17 Apr 2018 19:37:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*tom, H*RU:sk:gateway, Hx-spam-relays-external:sk:gateway X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.187.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Apr 2018 19:37:11 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id B0F83402AAE6C for ; Tue, 17 Apr 2018 14:37:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8WPdf8M6cy2aL8WPdfVYMG; Tue, 17 Apr 2018 14:37:09 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:35612 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f8WPd-000IXZ-Eb; Tue, 17 Apr 2018 14:37:09 -0500 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Set TYPE_NAME for Rust unions References: <20180412190756.16052-1-tom@tromey.com> <20180412190756.16052-3-tom@tromey.com> <20180413074052.lxdfiypb3kq6ulp3@adacore.com> Date: Tue, 17 Apr 2018 19:37:00 -0000 In-Reply-To: <20180413074052.lxdfiypb3kq6ulp3@adacore.com> (Joel Brobecker's message of "Fri, 13 Apr 2018 09:40:52 +0200") Message-ID: <87k1t5aal8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f8WPd-000IXZ-Eb X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:35612 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00350.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> 2018-04-12 Tom Tromey >> >> * dwarf2read.c (read_structure_type): Set TYPE_NAME for rust >> unions. Joel> The patch looks good to me, but I'd like to see if others have comments Joel> about C++. I'm trying to remember if C++ enums might have different Joel> rules compared to C enums, and I'm not remembering any... If there Joel> weren't any difference, and things were OK with C enums, one might Joel> think that we're OK for C++ enums as well... Joel> No way to test this either? I am not sure. However, my TYPE_TAG_NAME deletion patch is ready now (I'll send it momentarily), so I think we can just drop this one, because that patch obsoletes it. Tom