From: Tom Tromey <tom@tromey.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 7/8] Add truncate_repeat_arguments function
Date: Wed, 18 Oct 2017 03:48:00 -0000 [thread overview]
Message-ID: <87k1ztruap.fsf@tromey.com> (raw)
In-Reply-To: <86fuajwh8w.fsf@gmail.com> (Yao Qi's message of "Mon, 16 Oct 2017 10:53:51 +0100")
>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
Yao> This global variable worries me a little bit. Is it possible that
Yao> different part of GDB request to execute the repeatable commands? For
Yao> example, CLI and MI issues command, or different UIs issue command.
It's hard to reason about, I agree.
I think commands can either be run via "cmd_func", or by calling the
command function directly.
Direct calls can be directly audited -- and none of the callers of the
new set_repeat_arguments function are called this way.
There are also not many calls to cmd_func; and at least when I look at
these (I encourage you to check my work), I think only execute_command
can possibly call a command that calls set_repeat_arguments.
Since execute_command uses a scoped_restore to save and restore this
global, I think this must be ok.
It does seem a bit fragile. For example, I'd recommend not adding new
callers of set_repeat_arguments. I'm open to suggestions for another
way to approach this.
Tom
next prev parent reply other threads:[~2017-10-18 3:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 21:00 [RFA 0/8] Constify many commands Tom Tromey
2017-10-13 21:00 ` [RFA 6/8] Remove cleanup from backtrace_command Tom Tromey
2017-10-16 9:46 ` Yao Qi
2017-10-13 21:00 ` [RFA 2/8] Constify add_com_suppress_notification Tom Tromey
2017-10-16 9:03 ` Yao Qi
2017-10-16 15:55 ` Tom Tromey
2017-10-13 21:00 ` [RFA 8/8] Constify add_com Tom Tromey
2017-10-16 9:59 ` Yao Qi
2017-10-13 21:00 ` [RFA 1/8] Constify add_abbrev_prefix_cmd Tom Tromey
2017-10-16 9:02 ` Yao Qi
2017-10-16 15:54 ` Tom Tromey
2017-10-16 20:23 ` Yao Qi
2017-10-13 21:00 ` [RFA 5/8] Constify add_path and friends Tom Tromey
2017-10-16 9:35 ` Yao Qi
2017-10-13 21:00 ` [RFA 7/8] Add truncate_repeat_arguments function Tom Tromey
2017-10-14 4:49 ` Tom Tromey
2017-10-16 3:07 ` Tom Tromey
2017-10-16 9:53 ` Yao Qi
2017-10-18 3:48 ` Tom Tromey [this message]
2017-11-06 16:38 ` Tom Tromey
2017-11-07 14:35 ` Pedro Alves
2017-10-13 21:00 ` [RFA 3/8] Make set_cmd_cfunc private Tom Tromey
2017-10-16 9:20 ` Yao Qi
2017-10-13 21:00 ` [RFA 4/8] Make strip_bg_char return a unique_xmalloc_ptr Tom Tromey
2017-10-16 9:33 ` Yao Qi
2017-10-16 18:37 ` Simon Marchi
2017-10-17 11:05 ` Yao Qi
2017-10-18 3:32 ` Tom Tromey
2017-10-18 9:37 ` Pedro Alves
2017-11-06 16:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1ztruap.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).