From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23156 invoked by alias); 4 May 2015 02:34:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23140 invoked by uid 89); 4 May 2015 02:34:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 04 May 2015 02:34:00 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1Yp60U-0006Gr-6N; Mon, 04 May 2015 04:21:18 +0200 From: Gabriel Krisman Bertazi To: Pedro Alves Cc: Sergio Durigan Junior , gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v3 00/17] Catch syscall group References: <1430011521-24340-1-git-send-email-gabriel@krisman.be> <553F6BC0.9000905@redhat.com> <87r3r42e0v.fsf@redhat.com> <5540ABF8.4000404@redhat.com> Date: Mon, 04 May 2015 02:34:00 -0000 In-Reply-To: <5540ABF8.4000404@redhat.com> (Pedro Alves's message of "Wed, 29 Apr 2015 11:01:28 +0100") Message-ID: <87k2wpt6k6.fsf@krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00039.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 3426 Pedro Alves writes: > On 04/28/2015 09:28 PM, Sergio Durigan Junior wrote: >> On Tuesday, April 28 2015, Pedro Alves wrote: >>=20 >>> I was wondering if we couldn't share most of the grouping >>> per-architecture, e.g., by having each arch syscall file xi:include a >>> base Linux default groups file, that listed the grouping without >>> the syscall number. E.g., create a linux-defaults.xml like: >>> >> Thanks for the review, Pedro. I think this is a nice idea, but I would >> like to propose that we accept the patches as-is, without this >> improvement, and then work on it later. First, it's been a long time >> since we're discussing this feature, and I don't want Krisman to not >> feel encouraged to continue contributing :-).=20=20 > > I think there's a difference from the feature itself, which was > discussed and I'm generally fine with, and the whole set of patches that = are > new in this new revision of the series. Those are revealing a problem > that I think should be addressed. Hi Pedro and Sergio, Sorry for the time I took to reply to your emails. Contributing to GDB is something I do in my free time, and I only have such time on the weekends nowadays :-) So, first things first, thank you guys, for your review. > I'd like to hear what Gabriel thinks (both of my questions in the > previous email, and this one). Well, I think this could have come up earlier, so I could have fixed it already. As Sergio pointed out, it's been a few months since we started discussing this feature. :-) OTOH, I agree that Pedro's suggestion is much more maintainable than keeping the group information replicated in several xml files. As a matter of fact, when I first thought of this feature, I designed something like his first suggestion, and I'm not sure why I didn't go ahead with that plan. > OOC, does strace also maintain a separate group table per architecture? > Was your script something like a map of syscall _name_ to group? Strace maintains static tables holding syscall names, numbers and group information for each architecture separately. My script parsed those tables and mapped the syscall names in GDB's xmls to the group information from strace. > If there are grouping differences between the architectures (other > than which syscalls are wired/supported), Gabriel will have noticed > them, but that knowledge is lost (not encoded anywhere) in the > current form. I didn't see any difference in group allocation for the same syscall in different architectures. So this shouldn't be an issue. Pedro made two suggestions on how to proceed: (1) keep the information in a xml file and teach GDB about it or generate the full xml file during the build; (2) keep the group information inside a tabular text file and use a simple text substitution to generate the full xml during the build. Personally, even though I'm not a big fan of the XML format in general, I dislike option (2) because inserting a tabular text file now feels a little clumsy. since we already use XML for syscalls, I think syscall groups should be stored similarly. I plan to send a new version later this week (as soon as I have a break =46rom college) that implements Pedro's first suggestion. Now, we keep the information inside linux-defaults.xml and have a XSL script to performs a join of the information and generate the full XML file. Thanks! --=20 Gabriel Krisman Bertazi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVRtqJAAoJEO9pqxSS5VgP+pwP/jpn2vnRnFYsdSel2SZPg9br ZihbCVvN1t1XMBfhHKMpeM5Dt8eoB+doItn5K3U2NiWsh8YyAVk99pIzBtPhXHRZ guHBPY0zbmvm5M4isV0+tUBPlQ50qFwvpOIP7SybZhufsfuZkcUZI5FcH0jiKJFY yhrOP+NbaIShct4JpvXScY9jxc0nVo7OKO1tc3HZ9Kfspzfs2i59qE4CWC/ZDl2o sgliBuhhVfo2tlfAGUFyQAlFos/78yTY1edZTDgoXcuQtiDfTIxP8dz+XIwc+Rr5 m2cTnS5CVBDm6nNkb08B9/QlO9GJ4V1kdzPva4JrmolzOHJEwM5ERZp9jfo3jptz 6jl7eymaLvg5D/YhTBzEsV+0BFm5B0NUATM5ENb911YzDdSdxB9lB2eb6hfR0YdJ tTsl0ARtmU3iPwBwWs9bB3hxgQjtO4HjGUOZ8CzUh7pFh8LLgq3MqNQU6isTQQq8 DrWCvCg4HNMgmXMRkbjPtilQeTpfv499Rnv7384HRWnf34iJldXmFnLsTGYAJgKL jkqnMG08nT/fxjkviYYvDm2GPcQiKX+bj0OsL9PLoT+LM91whPJ75DCSgRZH3QlK ei6/t89Lbem4fqFF+ZadMhs2umwdIk3otcMWDjqQGdGmlQ52ZigRNrScgMfv0fU8 LuS+k2h9Y3j6u8/B6lAv =a4Qs -----END PGP SIGNATURE----- --=-=-=--