From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14854 invoked by alias); 17 Dec 2014 14:09:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14843 invoked by uid 89); 17 Dec 2014 14:09:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Dec 2014 14:09:03 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Y1FHf-0004IQ-QS from Yao_Qi@mentor.com ; Wed, 17 Dec 2014 06:08:59 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.181.6; Wed, 17 Dec 2014 06:08:59 -0800 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH 1/5] libthread_db: debug output should go to gdb_stdlog References: <1418748834-27545-1-git-send-email-palves@redhat.com> <1418748834-27545-2-git-send-email-palves@redhat.com> <871tnyu2k7.fsf@codesourcery.com> <549188E2.5000907@redhat.com> Date: Wed, 17 Dec 2014 14:09:00 -0000 In-Reply-To: <549188E2.5000907@redhat.com> (Pedro Alves's message of "Wed, 17 Dec 2014 13:45:06 +0000") Message-ID: <87k31qs714.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00484.txt.bz2 Pedro Alves writes: > Let me answer that by adding a comment. Does this make it clearer? Yes, it is clearer.... > > if (*libthread_db_search_path || libthread_db_debug) ... and it is also important to exchange them in the condition. > { > struct ui_file *file; > const char *library; > > library =3D dladdr_to_soname (*info->td_ta_new_p); > if (library =3D=3D NULL) > library =3D LIBTHREAD_DB_SO; > > /* If we'd print this to gdb_stdout when debug output is > disabled, still print it to gdb_stdout if debug output is > enabled. User visible output should not depend on debug > settings. */ --=20 Yao (=E9=BD=90=E5=B0=A7)