From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>
Cc: gdb-patches@sourceware.org, daniel.gutson@tallertechnologies.com
Subject: Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
Date: Tue, 25 Nov 2014 20:33:00 -0000 [thread overview]
Message-ID: <87k32jc96x.fsf@redhat.com> (raw)
In-Reply-To: <1416944088-8750-1-git-send-email-martin.galvan@tallertechnologies.com> (Martin Galvan's message of "Tue, 25 Nov 2014 16:34:48 -0300")
On Tuesday, November 25 2014, Martin Galvan wrote:
> I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it.
Hi Martin,
Thanks for the patch. I guess it is obvious enough that it could be
checked in without approval, but just to be safe, let's wait until a
maintainer approves it. Meanwhile...
> gdb/ChangeLog:
>
> 2014-11-25 Martin Galvan <martin.galvan@tallertechnologies.com>
>
> * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
The indentation of this ChangeLog entry is wrong. You must use TAB
instead of whitespaces to indent the "*" part.
> ---
>
> diff --git a/gdb/frame.c b/gdb/frame.c
> index 0663af9..135b820 100644
> --- a/gdb/frame.c
> +++ b/gdb/frame.c
> @@ -614,7 +614,7 @@ frame_id_eq (struct frame_id l, struct frame_id r)
> outer_frame_id. */
> eq = 1;
> else if (l.stack_status == FID_STACK_INVALID
> - || l.stack_status == FID_STACK_INVALID)
> + || r.stack_status == FID_STACK_INVALID)
Here, the use of whitespaces is wrong too. And it seems your e-mail
client has mangled the TAB of the old code as well.
> /* Like a NaN, if either ID is invalid, the result is false.
> Note that a frame ID is invalid iff it is the null frame ID. */
> eq = 0;
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-11-25 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 19:34 Martin Galvan
2014-11-25 20:33 ` Sergio Durigan Junior [this message]
2014-11-26 1:19 ` Martin Galvan
2014-11-30 15:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k32jc96x.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=daniel.gutson@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=martin.galvan@tallertechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).