From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26410 invoked by alias); 25 Nov 2014 20:33:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26392 invoked by uid 89); 25 Nov 2014 20:32:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 25 Nov 2014 20:32:57 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPKWt9F000928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Nov 2014 15:32:55 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAPKWtmg029407 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 25 Nov 2014 15:32:55 -0500 From: Sergio Durigan Junior To: Martin Galvan Cc: gdb-patches@sourceware.org, daniel.gutson@tallertechnologies.com Subject: Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq(). References: <1416944088-8750-1-git-send-email-martin.galvan@tallertechnologies.com> X-URL: http://blog.sergiodj.net Date: Tue, 25 Nov 2014 20:33:00 -0000 In-Reply-To: <1416944088-8750-1-git-send-email-martin.galvan@tallertechnologies.com> (Martin Galvan's message of "Tue, 25 Nov 2014 16:34:48 -0300") Message-ID: <87k32jc96x.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00630.txt.bz2 On Tuesday, November 25 2014, Martin Galvan wrote: > I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it. Hi Martin, Thanks for the patch. I guess it is obvious enough that it could be checked in without approval, but just to be safe, let's wait until a maintainer approves it. Meanwhile... > gdb/ChangeLog: > > 2014-11-25 Martin Galvan > > * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID. The indentation of this ChangeLog entry is wrong. You must use TAB instead of whitespaces to indent the "*" part. > --- > > diff --git a/gdb/frame.c b/gdb/frame.c > index 0663af9..135b820 100644 > --- a/gdb/frame.c > +++ b/gdb/frame.c > @@ -614,7 +614,7 @@ frame_id_eq (struct frame_id l, struct frame_id r) > outer_frame_id. */ > eq = 1; > else if (l.stack_status == FID_STACK_INVALID > - || l.stack_status == FID_STACK_INVALID) > + || r.stack_status == FID_STACK_INVALID) Here, the use of whitespaces is wrong too. And it seems your e-mail client has mangled the TAB of the old code as well. > /* Like a NaN, if either ID is invalid, the result is false. > Note that a frame ID is invalid iff it is the null frame ID. */ > eq = 0; -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/