From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2229 invoked by alias); 28 Sep 2014 12:36:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2216 invoked by uid 89); 28 Sep 2014 12:36:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 28 Sep 2014 12:36:32 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1XYDiG-0001Xu-Qh from Yao_Qi@mentor.com ; Sun, 28 Sep 2014 05:36:28 -0700 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.181.6; Sun, 28 Sep 2014 05:36:28 -0700 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH 3/9] Put single-step breakpoints on the bp_location chain References: <1411691982-10744-1-git-send-email-palves@redhat.com> <1411691982-10744-4-git-send-email-palves@redhat.com> Date: Sun, 28 Sep 2014 12:36:00 -0000 In-Reply-To: <1411691982-10744-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Fri, 26 Sep 2014 01:39:36 +0100") Message-ID: <87k34ovsc1.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00806.txt.bz2 Pedro Alves writes: > @@ -15496,22 +15466,9 @@ single_step_breakpoints_inserted (void) > void > remove_single_step_breakpoints (void) > { > - gdb_assert (single_step_breakpoints[0] !=3D NULL); > + gdb_assert (single_step_breakpoints !=3D NULL); >=20=20 > - /* See insert_single_step_breakpoint for more about this deprecated > - call. */ > - deprecated_remove_raw_breakpoint (single_step_gdbarch[0], > - single_step_breakpoints[0]); > - single_step_gdbarch[0] =3D NULL; > - single_step_breakpoints[0] =3D NULL; > - > - if (single_step_breakpoints[1] !=3D NULL) > - { > - deprecated_remove_raw_breakpoint (single_step_gdbarch[1], > - single_step_breakpoints[1]); > - single_step_gdbarch[1] =3D NULL; > - single_step_breakpoints[1] =3D NULL; > - } > + delete_breakpoint (single_step_breakpoints); We need to set single_step_breakpoints back to NULL. This causes many fails for arm-linux-gnueabi target, as I tested. --=20 Yao (=E9=BD=90=E5=B0=A7)